Re: [Qemu-arm] [PATCH v2 1/3] bcm2835_sdhost: add bcm2835 sdhost controller

[Peter Maydell]

On 22 February 2017 at 11:23, Clement Deschamps
<address@hidden> wrote:
> This adds the BCM2835 SDHost controller from Arasan.
>
> Signed-off-by: Clement Deschamps <address@hidden>
> ---
>  hw/sd/Makefile.objs            |   1 +
>  hw/sd/bcm2835_sdhost.c         | 429 
> +++++++++++++++++++++++++++++++++++++++++
>  include/hw/sd/bcm2835_sdhost.h |  48 +++++
>  3 files changed, 478 insertions(+)
>  create mode 100644 hw/sd/bcm2835_sdhost.c
>  create mode 100644 include/hw/sd/bcm2835_sdhost.h
>
> diff --git a/hw/sd/Makefile.objs b/hw/sd/Makefile.objs
> index 31c83308f2..c2b7664264 100644
> --- a/hw/sd/Makefile.objs
> +++ b/hw/sd/Makefile.objs
> @@ -6,3 +6,4 @@ common-obj-$(CONFIG_SDHCI) += sdhci.o
>  obj-$(CONFIG_MILKYMIST) += milkymist-memcard.o
>  obj-$(CONFIG_OMAP) += omap_mmc.o
>  obj-$(CONFIG_PXA2XX) += pxa2xx_mmci.o
> +obj-$(CONFIG_RASPI) += bcm2835_sdhost.o
> diff --git a/hw/sd/bcm2835_sdhost.c b/hw/sd/bcm2835_sdhost.c
> new file mode 100644
> index 0000000000..03c93ddb25
> --- /dev/null
> +++ b/hw/sd/bcm2835_sdhost.c
> @@ -0,0 +1,429 @@
> +/*
> + * Raspberry Pi (BCM2835) SD Host Controller
> + *
> + * Copyright (c) 2017 Antfield SAS
> + *
> + * Authors:
> + *  Clement Deschamps <address@hidden>
> + *  Luc Michel <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.
> + * See the COPYING file in the top-level directory.

GPL-2-only is OK if that's what you strongly want, but if all the
authors are OK with it we prefer GPL-2-or-later (see the note in
the LICENSE file). Similarly with the header file.

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM