[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/intc/arm_gicv3_its: Fix typo in m
From: |
Auger Eric |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/intc/arm_gicv3_its: Fix typo in member names of GICv3ITSState |
Date: |
Tue, 1 Nov 2016 16:42:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
Hi Stefan,
On 01/11/2016 16:28, Stefan Weil wrote:
> translater -> translator (found by codespell)
Actually GITS_TRANSLATER is the terminology used for this register in
the ARM GIC architecture specification (IHI0069B).
Thanks
Eric
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> hw/intc/arm_gicv3_its_kvm.c | 10 +++++-----
> include/hw/intc/arm_gicv3_its_common.h | 4 ++--
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c
> index fc246e0..c3e074d 100644
> --- a/hw/intc/arm_gicv3_its_kvm.c
> +++ b/hw/intc/arm_gicv3_its_kvm.c
> @@ -33,18 +33,18 @@ static int kvm_its_send_msi(GICv3ITSState *s, uint32_t
> value, uint16_t devid)
> {
> struct kvm_msi msi;
>
> - if (unlikely(!s->translater_gpa_known)) {
> + if (unlikely(!s->translator_gpa_known)) {
> MemoryRegion *mr = &s->iomem_its_translation;
> MemoryRegionSection mrs;
>
> mrs = memory_region_find(mr, 0, 1);
> memory_region_unref(mrs.mr);
> - s->gits_translater_gpa = mrs.offset_within_address_space + 0x40;
> - s->translater_gpa_known = true;
> + s->gits_translator_gpa = mrs.offset_within_address_space + 0x40;
> + s->translator_gpa_known = true;
> }
>
> - msi.address_lo = extract64(s->gits_translater_gpa, 0, 32);
> - msi.address_hi = extract64(s->gits_translater_gpa, 32, 32);
> + msi.address_lo = extract64(s->gits_translator_gpa, 0, 32);
> + msi.address_hi = extract64(s->gits_translator_gpa, 32, 32);
> msi.data = le32_to_cpu(value);
> msi.flags = KVM_MSI_VALID_DEVID;
> msi.devid = devid;
> diff --git a/include/hw/intc/arm_gicv3_its_common.h
> b/include/hw/intc/arm_gicv3_its_common.h
> index 1ba1894..00aa04d 100644
> --- a/include/hw/intc/arm_gicv3_its_common.h
> +++ b/include/hw/intc/arm_gicv3_its_common.h
> @@ -38,8 +38,8 @@ struct GICv3ITSState {
> GICv3State *gicv3;
>
> int dev_fd; /* kvm device fd if backed by kvm vgic support */
> - uint64_t gits_translater_gpa;
> - bool translater_gpa_known;
> + uint64_t gits_translator_gpa;
> + bool translator_gpa_known;
>
> /* Registers */
> uint32_t ctlr;
>