[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] ACPI: Add -acpifadt to allow FADT re
From: |
no-reply |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] ACPI: Add -acpifadt to allow FADT revision changes |
Date: |
Mon, 8 Aug 2016 00:35:02 -0700 (PDT) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH] ACPI: Add -acpifadt to allow FADT revision changes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
10f0124 ACPI: Add -acpifadt to allow FADT revision changes
=== OUTPUT BEGIN ===
Checking PATCH 1/1: ACPI: Add -acpifadt to allow FADT revision changes...
ERROR: code indent should never use tabs
#31: FILE: hw/i386/acpi-build.c:281:
+^I uint8_t bit_width, uint8_t bit_offset,$
ERROR: code indent should never use tabs
#32: FILE: hw/i386/acpi-build.c:282:
+^I uint8_t access_width, uint64_t address)$
ERROR: spaces required around that '=' (ctx:VxW)
#37: FILE: hw/i386/acpi-build.c:287:
+ gas->access_width= access_width;
^
WARNING: consider using qemu_strtoul in preference to strtoul
#187: FILE: vl.c:2310:
+ rev = strtoul(arg, NULL, 0);
total: 3 errors, 1 warnings, 162 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
- [Qemu-arm] [PATCH] ACPI: Add -acpifadt to allow FADT revision changes, Lv Zheng, 2016/08/08
- [Qemu-arm] [PATCH v2] ACPI: Add -acpifadt to allow FADT revision changes, Lv Zheng, 2016/08/08
- Re: [Qemu-arm] [PATCH] ACPI: Add -acpifadt to allow FADT revision changes, Igor Mammedov, 2016/08/08
- Re: [Qemu-arm] [Qemu-devel] [PATCH] ACPI: Add -acpifadt to allow FADT revision changes,
no-reply <=
- [Qemu-arm] [PATCH v3 0/2] ACPI: Add FADT revision support, Lv Zheng, 2016/08/11
- [Qemu-arm] [PATCH v4 0/2] ACPI: Add FADT revision support, Lv Zheng, 2016/08/11
- [Qemu-arm] [PATCH v5 0/2] ACPI: Add FADT revision support, Lv Zheng, 2016/08/11