Re: [Qemu-arm] [PATCH] bcm2835_property: implement "get board revision" query

[Andrew Baumann]

Hi Stephen,

Thanks for the patch!

> From: Stephen Warren [mailto:address@hidden
> Sent: Sunday, 7 February 2016 4:09 PM
> 
> Return a valid value from the BCM2835 property mailbox query "get board
> revision". This query is used by U-Boot. Implementing it fixes the first
> obvious difference between qemu and real HW.
> 
> The value returned is currently hard-coded to match the RPi2 I own. Other
> values are legal, e.g. different board manufacturer field values are likely to
> exist in the wild. When support for other RPi models is added, the value can
> be made dynamic.
> 
> Cc: Andrew Baumann <address@hidden>
> Signed-off-by: Stephen Warren <address@hidden>
> ---
> This looks like the only non-video-related mailbox request used by U-Boot
> that wasn't implemented by qemu.
> 
> The only other feature required for U-Boot to get to its command prompt is
> the BCM2835 timer.
> 
> Andrew, I assume you're actively working on mainlining all the features in
> your github branch? I look forward to U-Boot working on qemu:-)

That's right, although I probably won't get the next round of patches out until 
late Feb. However, my goal in that series is to merge support for Pi1, so:

* Do you know where we can find the appropriate values for Pi1 boards?
* Can you please propagate the board-rev property through bcm2835_peripherals 
and bcm2836 so that the appropriate value is being set in the board definition 
file (raspi.c)? This should be as simple as a few calls to 
object_property_add_alias(), e.g.:
https://github.com/0xabu/qemu/blob/raspi/hw/arm/bcm2836.c#L42

Thanks,
Andrew