[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v10 6/7] hw/ptimer: Introduce ptimer_get_limit
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-arm] [PATCH v10 6/7] hw/ptimer: Introduce ptimer_get_limit |
Date: |
Mon, 11 Jan 2016 19:59:13 -0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Jan 09, 2016 at 08:39:54PM +0300, Dmitry Osipenko wrote:
> Currently ptimer users are used to store copy of the limit value, because
> ptimer doesn't provide facility to retrieve the limit. Let's provide it.
>
> Signed-off-by: Dmitry Osipenko <address@hidden>
Fair call. One less piece of duped state for the VMSDs.
Reviewed-by: Peter Crosthwaite <address@hidden>
Regards,
Peter
> ---
> hw/core/ptimer.c | 5 +++++
> include/hw/ptimer.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
> index 42e44f9..0201d1b 100644
> --- a/hw/core/ptimer.c
> +++ b/hw/core/ptimer.c
> @@ -235,6 +235,11 @@ void ptimer_set_limit(ptimer_state *s, uint64_t limit,
> int reload)
> }
> }
>
> +uint64_t ptimer_get_limit(ptimer_state *s)
> +{
> + return s->limit;
> +}
> +
> const VMStateDescription vmstate_ptimer = {
> .name = "ptimer",
> .version_id = 1,
> diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h
> index 8ebacbb..e397db5 100644
> --- a/include/hw/ptimer.h
> +++ b/include/hw/ptimer.h
> @@ -19,6 +19,7 @@ typedef void (*ptimer_cb)(void *opaque);
> ptimer_state *ptimer_init(QEMUBH *bh);
> void ptimer_set_period(ptimer_state *s, int64_t period);
> void ptimer_set_freq(ptimer_state *s, uint32_t freq);
> +uint64_t ptimer_get_limit(ptimer_state *s);
> void ptimer_set_limit(ptimer_state *s, uint64_t limit, int reload);
> uint64_t ptimer_get_count(ptimer_state *s);
> void ptimer_set_count(ptimer_state *s, uint64_t count);
> --
> 2.6.4
>
[Qemu-arm] [PATCH v10 7/7] arm_mptimer: Convert to use ptimer, Dmitry Osipenko, 2016/01/09