qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH] target-*: Get rid of "PC advancement


From: Richard Henderson
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH] target-*: Get rid of "PC advancement" trick
Date: Wed, 16 Dec 2015 09:03:44 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0

On 12/15/2015 01:02 PM, Sergey Fedorov wrote:
For that, I think it might be interesting to arrange for non-empty TBs to
exit prior to recognizing a breakpoint.  So that a breakpoint TB is always
just the one operation.  Except for the fact that "generate an exception" has
traditionally been a target-specific helper, we could almost make the entire
breakpoint generation be done in common code.

I'd think something like a generic "must we end the TB now" predicate would
be the proper hook.  It would contain all of the usual stuff: tcg_op_buf_full
and checks for singlestep, but then add "is there a breakpoint at the next pc".

This could be a next step :)

Or perhaps a first step, since the patch you posted doesn't seem to me to be an improvement at all, merely a rearrangement of code.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]