Send pspp-dev mailing list submissions to
address@hidden
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.gnu.org/mailman/listinfo/pspp-dev
or, via email, send a message with subject or body 'help' to
address@hidden
You can reach the person managing the list at
address@hidden
When replying, please edit your Subject line so it is more specific
than "Re: Contents of pspp-dev digest..."
Today's Topics:
1. New German PO file for 'pspp' (version 0.8.5)
(Translation Project Robot)
2. Re: Bug #47090 (Friedrich Beckmann)
3. DECIMAL=COMMA in DATA LIST command (Bug #47253)
(Friedrich Beckmann)
4. Re: Bug #47090 (John Darrington)
----------------------------------------------------------------------
Message: 1
Date: Thu, 25 Feb 2016 09:27:14 +0100
From: Translation Project Robot <address@hidden>
To: address@hidden
Subject: New German PO file for 'pspp' (version 0.8.5)
Message-ID: <address@hidden>
Hello, gentle maintainer.
This is a message from the Translation Project robot.
A revised PO file for textual domain 'pspp' has been submitted
by the German team of translators. The file is available at:
http://translationproject.org/latest/pspp/de.po
(We can arrange things so that in the future such files are automatically
e-mailed to you when they arrive. Ask at the address below if you want this.)
All other PO files for your package are available in:
http://translationproject.org/latest/pspp/
Please consider including all of these in your next release, whether
official or a pretest.
Whenever you have a new distribution with a new version number ready,
containing a newer POT file, please send the URL of that distribution
tarball to the address below. The tarball may be just a pretest or a
snapshot, it does not even have to compile. It is just used by the
translators when they need some extra translation context.
The following HTML page has been updated:
http://translationproject.org/domain/pspp.html
If any question arises, please contact the translation coordinator.
Thank you for all your work,
The Translation Project robot, in the
name of your translation coordinator.
<address@hidden>
------------------------------
Message: 2
Date: Thu, 25 Feb 2016 10:02:28 +0100
From: Friedrich Beckmann <address@hidden>
To: John Darrington <address@hidden>
Cc: address@hidden
Subject: Re: Bug #47090
Message-ID: <address@hidden>
Content-Type: text/plain; charset="us-ascii"
Hi John,
Am 24.02.2016 um 17:21 schrieb John Darrington <address@hidden>:
I think that once Bug #47090 and Bug #42086 have been fixed, so
long as no new issues have arisen, it will be time to make a new
release.
Maybe it is an idea to first include your efficient sheet, before thinking
about a new release. I still
have the impression that pspp-sheet-view is lets say difficult in gtk3. See
even from today:
https://savannah.gnu.org/bugs/index.php?47251
<https://savannah.gnu.org/bugs/index.php?47251>
Thinking about a release means thinking about pspp-sheet-view and maybe that is
wrong
because it puts efforts in the wrong place.
Regarding Bug #47090:
In our current git HEAD operations on the sheet are of complexity
O(n^2) in the number of columns. This means that operations on data,
when there are a large number of variables are unacceptably slow.
I have to wait longer than 5 minutes for an operation on 2500 variables
to complete (it is almost instantaneous without the GUI).
Ideally, these operations can be done with O(1) complexity, and that
is what happens with the "efficient-sheet" I have been working on.
However that is not going to be ready for public consumption in the
next few weeks.
In release 0.8.5 this operation was O(n) so I think we should look
for a short term solution which restores this behaviour.
I can see two possible solutions:
Solution 1:
Revert commit 8298a4c6e326a39e204ca58d686497758333a102.
This commit by Friedrich appears to have undone an earlier optimisation.
Friedrich can be elaborate on the bug you noticed which prompted you
to make this commit? Maybe there is another solution?
>From the commit message:
<msg>
fixed initial show of names in header window. Variable names only showed up
after switching between variable and data window. The reason is that the
buttons of the columns are not created. This is due to interdependency between
the size allocation and the button creation. I removed the need_button
mechanism.
</msg>
I remember the problem about the window update. But I would rather put my
efforts into the efficient sheet.
And below: Maybe it works. But it means thinking about sheet-view.
Solution 2:
The patch below fixes the time complexity, and so far as I can see
introduces no adverse effects. However I haven't done any very
thorough testing.
It removes a loop which calls _pspp_sheet_view_column_cell_set_dirty
on all the columns. Note that the function
_pspp_sheet_view_column_cell_set_dirty
sets a flag:
tree_column->dirty = TRUE;
but there is nothing in our code which reads this flag or unsets it.
Perhaps it is here only for historical reasons?
From 54d20e902513f7a890c727cc45d31dceb64679ed Mon Sep 17 00:00:00 2001
From: John Darrington <address@hidden>
Date: Wed, 24 Feb 2016 09:21:36 +0100
Subject: [PATCH] pspp-sheet-view.c: Remove inner loop from column insertion
and removal operations
This appears to do no harm and moves the complexity from O(n^2) to O(n).
From 54d20e902513f7a890c727cc45d31dceb64679ed Mon Sep 17 00:00:00 2001
From: John Darrington <address@hidden>
Date: Wed, 24 Feb 2016 09:21:36 +0100
Subject: [PATCH] pspp-sheet-view.c: Remove inner loop from column insertion
and removal operations
This appears to do no harm and moves the complexity from O(n^2) to O(n).
---
src/ui/gui/pspp-sheet-view.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/src/ui/gui/pspp-sheet-view.c b/src/ui/gui/pspp-sheet-view.c
index fe70504..7ff7569 100644
--- a/src/ui/gui/pspp-sheet-view.c
+++ b/src/ui/gui/pspp-sheet-view.c
@@ -8927,14 +8927,6 @@ pspp_sheet_view_remove_column (PsppSheetView
*tree_view,
GList *list;
_pspp_sheet_view_column_unrealize_button (column);
- for (list = tree_view->priv->columns; list; list = list->next)
- {
- PsppSheetViewColumn *tmp_column;
-
- tmp_column = PSPP_SHEET_VIEW_COLUMN (list->data);
- if (tmp_column->visible)
- _pspp_sheet_view_column_cell_set_dirty (tmp_column);
- }
if (tree_view->priv->n_columns == 0 &&
pspp_sheet_view_get_headers_visible (tree_view) &&
@@ -8991,12 +8983,6 @@ pspp_sheet_view_insert_column (PsppSheetView
*tree_view,
_pspp_sheet_view_column_realize_button (column);
- for (list = tree_view->priv->columns; list; list = list->next)
- {
- column = PSPP_SHEET_VIEW_COLUMN (list->data);
- if (column->visible)
- _pspp_sheet_view_column_cell_set_dirty (column);
- }
gtk_widget_queue_resize (GTK_WIDGET (tree_view));
}
--
2.1.4
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.gnu.org/archive/html/pspp-dev/attachments/20160225/52ce0455/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL:
<http://lists.gnu.org/archive/html/pspp-dev/attachments/20160225/52ce0455/attachment.pgp>
------------------------------
Message: 3
Date: Thu, 25 Feb 2016 11:35:06 +0100
From: Friedrich Beckmann <address@hidden>
To: Ben Pfaff <address@hidden>
Cc: address@hidden
Subject: DECIMAL=COMMA in DATA LIST command (Bug #47253)
Message-ID: <address@hidden>
Content-Type: text/plain; charset="us-ascii"
Hi Ben,
John proposed a patch to fix the problem of the COMMA as decimal point in the
data list command:
https://savannah.gnu.org/bugs/?47253 <https://savannah.gnu.org/bugs/?47253>
and he mentioned that you should / would maybe have a look at the proposed
patch. For me the patch works.
Friedrich
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.gnu.org/archive/html/pspp-dev/attachments/20160225/15bd093b/attachment.html>
------------------------------
Message: 4
Date: Thu, 25 Feb 2016 14:27:32 +0100
From: John Darrington <address@hidden>
To: Friedrich Beckmann <address@hidden>
Cc: address@hidden, John Darrington <address@hidden>
Subject: Re: Bug #47090
Message-ID: <address@hidden>
Content-Type: text/plain; charset="us-ascii"
I fully agree that we should not spend a lot of effort on the existing sheet.
At the same time, especially considering the recent discussion on pspp-users, I
think we should be making a release asap. The "efficient-sheet" is not going
to be ready for at least 3 months. I don't think it sensible to wait that long.
My thinking is to resolve this outstanding criticical bug in a way which
requires
minimal effort, make a release and then concentrate on the new efficient sheet.
J'
On Thu, Feb 25, 2016 at 10:02:28AM +0100, Friedrich Beckmann wrote:
Hi John,
> Am 24.02.2016 um 17:21 schrieb John Darrington <address@hidden>:
>
> I think that once Bug #47090 and Bug #42086 have been fixed, so
> long as no new issues have arisen, it will be time to make a new
> release.
>
Maybe it is an idea to first include your efficient sheet, before thinking about a new release. I still
have the impression that pspp-sheet-view is lets say difficult in gtk3.
See even from today:
https://savannah.gnu.org/bugs/index.php?47251 <https://savannah.gnu.org/bugs/index.php?47251>
Thinking about a release means thinking about pspp-sheet-view and maybe that is wrong
because it puts efforts in the wrong place.
> Regarding Bug #47090:
>
> In our current git HEAD operations on the sheet are of complexity
> O(n^2) in the number of columns. This means that operations on data,
> when there are a large number of variables are unacceptably slow.
> I have to wait longer than 5 minutes for an operation on 2500 variables
> to complete (it is almost instantaneous without the GUI).
>
> Ideally, these operations can be done with O(1) complexity, and that
> is what happens with the "efficient-sheet" I have been working on.
> However that is not going to be ready for public consumption in the
> next few weeks.
>
> In release 0.8.5 this operation was O(n) so I think we should look
> for a short term solution which restores this behaviour.
>
> I can see two possible solutions:
>
> Solution 1:
>
> Revert commit 8298a4c6e326a39e204ca58d686497758333a102.
>
> This commit by Friedrich appears to have undone an earlier optimisation.
> Friedrich can be elaborate on the bug you noticed which prompted you
> to make this commit? Maybe there is another solution?
From the commit message:
<msg>
fixed initial show of names in header window. Variable names only showed
up after switching between variable and data window. The reason is that the
buttons of the columns are not created. This is due to interdependency between
the size allocation and the button creation. I removed the need_button
mechanism.
</msg>
I remember the problem about the window update. But I would rather put my efforts into the efficient sheet.
And below: Maybe it works. But it means thinking about sheet-view.
> Solution 2:
>
> The patch below fixes the time complexity, and so far as I can see
> introduces no adverse effects. However I haven't done any very
> thorough testing.
>
> It removes a loop which calls _pspp_sheet_view_column_cell_set_dirty
> on all the columns. Note that the function
_pspp_sheet_view_column_cell_set_dirty
> sets a flag:
> tree_column->dirty = TRUE;
> but there is nothing in our code which reads this flag or unsets it.
> Perhaps it is here only for historical reasons?
>
>
>
>
>
>
>
> From 54d20e902513f7a890c727cc45d31dceb64679ed Mon Sep 17 00:00:00 2001
> From: John Darrington <address@hidden>
> Date: Wed, 24 Feb 2016 09:21:36 +0100
> Subject: [PATCH] pspp-sheet-view.c: Remove inner loop from column
insertion
> and removal operations
>
> This appears to do no harm and moves the complexity from O(n^2) to O(n).
>
>
> From 54d20e902513f7a890c727cc45d31dceb64679ed Mon Sep 17 00:00:00 2001
> From: John Darrington <address@hidden>
> Date: Wed, 24 Feb 2016 09:21:36 +0100
> Subject: [PATCH] pspp-sheet-view.c: Remove inner loop from column
insertion
> and removal operations
>
> This appears to do no harm and moves the complexity from O(n^2) to O(n).
> ---
> src/ui/gui/pspp-sheet-view.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/src/ui/gui/pspp-sheet-view.c b/src/ui/gui/pspp-sheet-view.c
> index fe70504..7ff7569 100644
> --- a/src/ui/gui/pspp-sheet-view.c
> +++ b/src/ui/gui/pspp-sheet-view.c
> @@ -8927,14 +8927,6 @@ pspp_sheet_view_remove_column (PsppSheetView
*tree_view,
> GList *list;
>
> _pspp_sheet_view_column_unrealize_button (column);
> - for (list = tree_view->priv->columns; list; list = list->next)
> - {
> - PsppSheetViewColumn *tmp_column;
> -
> - tmp_column = PSPP_SHEET_VIEW_COLUMN (list->data);
> - if (tmp_column->visible)
> - _pspp_sheet_view_column_cell_set_dirty (tmp_column);
> - }
>
> if (tree_view->priv->n_columns == 0 &&
> pspp_sheet_view_get_headers_visible (tree_view) &&
> @@ -8991,12 +8983,6 @@ pspp_sheet_view_insert_column (PsppSheetView
*tree_view,
>
> _pspp_sheet_view_column_realize_button (column);
>
> - for (list = tree_view->priv->columns; list; list = list->next)
> - {
> - column = PSPP_SHEET_VIEW_COLUMN (list->data);
> - if (column->visible)
> - _pspp_sheet_view_column_cell_set_dirty (column);
> - }
> gtk_widget_queue_resize (GTK_WIDGET (tree_view));
> }
>
> --
> 2.1.4
>