pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch for review


From: John Darrington
Subject: Re: patch for review
Date: Thu, 3 Oct 2013 09:04:26 +0200
User-agent: Mutt/1.5.20 (2009-06-14)

On Wed, Oct 02, 2013 at 09:56:05PM -0700, Ben Pfaff wrote:
     On Wed, Oct 02, 2013 at 04:39:06PM +0200, John Darrington wrote:
     > I'd appreciate a review of this patch before I push it.  Thanks.
     
     The old code and the new code make sense to me, I think.  It's not
     obvious to me how it will simplify upcoming code (or what that code will
     do), but it seems fine.

     It might use a few comments, especially in the new header file, to
     explain the overall purpose of the object.  The commit message explains
     it a little bit, but it would be useful to have that in the code too.

You're right.  I'll add some comments and check it in.  Thanks for the review.

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]