Re: known psppsheet bugs

[Ben Pfaff]

John Darrington <address@hidden> writes:

> On Wed, Nov 07, 2012 at 12:47:00PM -0800, Ben Pfaff wrote:
>      Ben Pfaff <address@hidden> writes:
>      
>      > John Darrington <address@hidden> writes:
>      >
>      >> On Mon, Nov 05, 2012 at 10:00:07AM -0800, Ben Pfaff wrote:
>      >>      Here's the current list of known bugs specific to the psppsheet
>      >>      branch.  I'd like comments on which ones seem important enough to
>      >>      fix before merging.
>      >>      
>      >>      
>      >>      jmd: 2. Double click on  a row header button.
>      >>      jmd: 3. The view (correctly) switches to the data view.  But it 
> should also change the selected cell to the variable corresponding to the row 
> that was clicked.  It doesn't do that.
>      >>      
>      >>
>      >> This one is worse than I thought.  Not only is it not doing
>      >> what it should, but about 1 in 3 attempts it crashes.
>      >
>      > That's really bad.  I'll fix it.  Thanks for reporting that.
>      
>      I don't see the crashes here, do you have a backtrace or other
>      analysis?  Anything special you have to do to make it crash?
>
> The backtrace shows several thousand frames like this:
>
> #0  0xb76b94bd in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
> #1  0xb76b9ebd in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
> #2  0x080868e1 in psppire_button_editable_button_release (widget=0x8278c50, 
>     event=0x828eee8)
>     at /home/john/pspp-sheet/src/ui/gui/psppire-button-editable.c:120
> #3  0xb7b0ee74 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
> #4  0xb76a07a9 in ?? () from /usr/lib/libgobject-2.0.so.0
> #5  0xb76a2068 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
> #6  0xb76b8266 in ?? () from /usr/lib/libgobject-2.0.so.0
> #7  0xb76b9a7b in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
> #8  0xb76b9ebd in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
> #9  0x080868e1 in psppire_button_editable_button_release (widget=0x8278c50, 
>     event=0x828eee8)
>     at /home/john/pspp-sheet/src/ui/gui/psppire-button-editable.c:120
> #10 0xb7b0ee74 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
> #11 0xb76a07a9 in ?? () from /usr/lib/libgobject-2.0.so.0
> #12 0xb76a2068 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
> #13 0xb76b8266 in ?? () from /usr/lib/libgobject-2.0.so.0
> #14 0xb76b9a7b in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
> #15 0xb76b9ebd in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
> #16 0x080868e1 in psppire_button_editable_button_release (widget=0x8278c50, 
>     event=0x828eee8)
>
> Suggesting that the signal emission on line 120 is causing 
> psppire_button_editable_button_release to be called again.
> As for provoking the problem, I 
> 1. opened the file "hotel.sav" in the examples directory,
> 2. Switched back and forth several times between dataview and variable view 
> by double clicking on the column/row header buttons.
> 3. After a few times of doing that, it crashes.  
>
> It doesn't seem to be deterministic, but it always crashes when stwitching 
> from variable view to data view.

I fixed this problem.  Thanks!