Re: scanner / lexer problem in GUI

[Ben Pfaff]

John Darrington <address@hidden> writes:

> Looking at the bug recently reported on bug-gnu-pspp I notice the following.
>
> Valgrind reports:
>
> Invalid read of size 1
> ==25266==    at 0x41AC189: u8_mbtouc (u8-mbtouc.c:33)
> ==25266==    by 0x40495FD: count_columns (lexer.c:977)
> ==25266==    by 0x4049777: lex_source_get_last_column (lexer.c:1010)
> ==25266==    by 0x404A10E: lex_source_error_valist (lexer.c:1328)
> ==25266==    by 0x4048810: lex_next_error_valist (lexer.c:392)
> ==25266==    by 0x40482C5: lex_error (lexer.c:247)
> ==25266==    by 0x4048E62: lex_force_string (lexer.c:623)
> ==25266==    by 0x405E8CC: cmd_variable_labels (variable-label.c:50)
> ==25266==    by 0x40468FE: do_parse_command (command.c:222)
> ==25266==    by 0x404662F: cmd_parse_in_state (command.c:136)
> ==25266==    by 0x4046713: cmd_parse (command.c:152)
> ==25266==    by 0x8097815: execute_syntax (executor.c:121)
> ==25266==  Address 0x69f27d8 is 0 bytes after a block of size 144 alloc'd
> ==25266==    at 0x4024046: realloc (vg_replace_malloc.c:525)
> ==25266==    by 0x41AD940: xrealloc (xmalloc.c:63)
> ==25266==    by 0x41AD89B: x2nrealloc (xalloc.h:215)
> ==25266==    by 0x41AD989: x2realloc (xmalloc.c:78)
> ==25266==    by 0x4049BE6: lex_source_expand__ (lexer.c:1197)
> ==25266==    by 0x4049C15: lex_source_read__ (lexer.c:1214)
> ==25266==    by 0x404A2C9: lex_source_get__ (lexer.c:1399)
> ==25266==    by 0x4048241: lex_get (lexer.c:228)
> ==25266==    by 0x4046982: do_parse_command (command.c:235)
> ==25266==    by 0x404662F: cmd_parse_in_state (command.c:136)
> ==25266==    by 0x4046713: cmd_parse (command.c:152)
> ==25266==    by 0x8097815: execute_syntax (executor.c:121)

Funny, I get different valgrind report:

==21886== Invalid read of size 1
==21886==    at 0x4E93697: segmenter_parse_string__ (segment.c:757)
==21886==    by 0x4E957C0: segmenter_parse_mid_command__ (segment.c:899)
==21886==    by 0x4E943F4: segmenter_push (segment.c:1546)
==21886==    by 0x4E9073B: lex_source_get__ (lexer.c:1396)
==21886==    by 0x4E912D8: lex_get (lexer.c:228)
==21886==    by 0x4E96887: parse_vs_variable_idx (variable-parser.c:72)
==21886==    by 0x4E96916: parse_var_idx_class (variable-parser.c:159)
==21886==    by 0x4E974EA: parse_var_set_vars (variable-parser.c:294)
==21886==    by 0x4E9793D: parse_variables (variable-parser.c:121)
==21886==    by 0x4EA3EBC: cmd_variable_labels (variable-label.c:47)
==21886==    by 0x4E8EB94: cmd_parse_in_state (command.c:222)
==21886==    by 0x4E8F027: cmd_parse (command.c:152)
==21886==    by 0x808EA1B: execute_syntax (executor.c:121)
==21886==    by 0x80AB1E3: on_run_all (psppire-syntax-window.c:446)
==21886==    by 0x78F1CAB: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==21886==    by 0x78E4139: g_closure_invoke (gclosure.c:767)
==21886==    by 0x78FA61C: signal_emit_unlocked_R (gsignal.c:3248)
==21886==    by 0x78FBBFB: g_signal_emit_valist (gsignal.c:2981)
==21886==    by 0x78FC075: g_signal_emit (gsignal.c:3038)
==21886==    by 0x7257BB4: _gtk_action_emit_activate (gtkaction.c:755)
==21886==    by 0x7259CBC: gtk_action_activate (gtkaction.c:785)
==21886==    by 0x78F1CAB: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==21886==    by 0x78E27A8: g_type_class_meta_marshal (gclosure.c:878)
==21886==    by 0x78E4139: g_closure_invoke (gclosure.c:767)
==21886==    by 0x78F9EB9: signal_emit_unlocked_R (gsignal.c:3178)
==21886==    by 0x78FBBFB: g_signal_emit_valist (gsignal.c:2981)
==21886==    by 0x78FC075: g_signal_emit (gsignal.c:3038)
==21886==    by 0x745FF04: gtk_widget_activate (gtkwidget.c:4974)
==21886==    by 0x733F3FF: gtk_menu_shell_activate_item (gtkmenushell.c:1256)
==21886==    by 0x7340ECE: gtk_menu_shell_button_release (gtkmenushell.c:683)
==21886==    by 0x73366C3: gtk_menu_button_release (gtkmenu.c:3005)
==21886==    by 0x732FE73: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:84)
==21886==    by 0x78E27A8: g_type_class_meta_marshal (gclosure.c:878)
==21886==    by 0x78E4139: g_closure_invoke (gclosure.c:767)
==21886==    by 0x78FA265: signal_emit_unlocked_R (gsignal.c:3286)
==21886==    by 0x78FBA7A: g_signal_emit_valist (gsignal.c:2991)
==21886==    by 0x78FC075: g_signal_emit (gsignal.c:3038)
==21886==    by 0x745C155: gtk_widget_event_internal (gtkwidget.c:4943)
==21886==    by 0x73284CC: gtk_propagate_event (gtkmain.c:2442)
==21886==    by 0x7329856: gtk_main_do_event (gtkmain.c:1647)
==21886==    by 0x761EDD9: gdk_event_dispatch (gdkevents-x11.c:2372)
==21886==    by 0x7F18304: g_main_context_dispatch (gmain.c:1960)
==21886==    by 0x7F1BFE7: g_main_context_iterate (gmain.c:2591)
==21886==    by 0x7F1C526: g_main_loop_run (gmain.c:2799)
==21886==    by 0x7329E18: gtk_main (gtkmain.c:1219)
==21886==    by 0x809292C: run_inner_loop (main.c:233)
==21886==    by 0x7329F80: gtk_main (gtkmain.c:2339)
==21886==    by 0x8092862: main (main.c:333)
==21886==  Address 0xd803d60 is 0 bytes after a block of size 144 alloc'd
==21886==    at 0x49E0046: realloc (vg_replace_malloc.c:525)
==21886==    by 0x4FCAD9C: xrealloc (xmalloc.c:63)
==21886==    by 0x4FCAE1E: x2realloc (xalloc.h:215)
==21886==    by 0x4E9000C: lex_source_expand__ (lexer.c:1197)
==21886==    by 0x4E907B6: lex_source_get__ (lexer.c:1214)
==21886==    by 0x4E912D8: lex_get (lexer.c:228)
==21886==    by 0x4E8E81F: cmd_parse_in_state (command.c:235)
==21886==    by 0x4E8F027: cmd_parse (command.c:152)
==21886==    by 0x808EA1B: execute_syntax (executor.c:121)
==21886==    by 0x80AB1E3: on_run_all (psppire-syntax-window.c:446)
==21886==    by 0x78F1CAB: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==21886==    by 0x78E4139: g_closure_invoke (gclosure.c:767)
==21886==    by 0x78FA61C: signal_emit_unlocked_R (gsignal.c:3248)
==21886==    by 0x78FBBFB: g_signal_emit_valist (gsignal.c:2981)
==21886==    by 0x78FC075: g_signal_emit (gsignal.c:3038)
==21886==    by 0x7257BB4: _gtk_action_emit_activate (gtkaction.c:755)
==21886==    by 0x7259CBC: gtk_action_activate (gtkaction.c:785)
==21886==    by 0x78F1CAB: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==21886==    by 0x78E27A8: g_type_class_meta_marshal (gclosure.c:878)
==21886==    by 0x78E4139: g_closure_invoke (gclosure.c:767)
==21886==    by 0x78F9EB9: signal_emit_unlocked_R (gsignal.c:3178)
==21886==    by 0x78FBBFB: g_signal_emit_valist (gsignal.c:2981)
==21886==    by 0x78FC075: g_signal_emit (gsignal.c:3038)
==21886==    by 0x745FF04: gtk_widget_activate (gtkwidget.c:4974)
==21886==    by 0x733F3FF: gtk_menu_shell_activate_item (gtkmenushell.c:1256)
==21886==    by 0x7340ECE: gtk_menu_shell_button_release (gtkmenushell.c:683)
==21886==    by 0x73366C3: gtk_menu_button_release (gtkmenu.c:3005)
==21886==    by 0x732FE73: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:84)
==21886==    by 0x78E27A8: g_type_class_meta_marshal (gclosure.c:878)
==21886==    by 0x78E4139: g_closure_invoke (gclosure.c:767)
==21886==    by 0x78FA265: signal_emit_unlocked_R (gsignal.c:3286)
==21886==    by 0x78FBA7A: g_signal_emit_valist (gsignal.c:2991)
==21886==    by 0x78FC075: g_signal_emit (gsignal.c:3038)
==21886==    by 0x745C155: gtk_widget_event_internal (gtkwidget.c:4943)
==21886==    by 0x73284CC: gtk_propagate_event (gtkmain.c:2442)
==21886==    by 0x7329856: gtk_main_do_event (gtkmain.c:1647)
==21886==    by 0x761EDD9: gdk_event_dispatch (gdkevents-x11.c:2372)
==21886==    by 0x7F18304: g_main_context_dispatch (gmain.c:1960)
==21886==    by 0x7F1BFE7: g_main_context_iterate (gmain.c:2591)
==21886==    by 0x7F1C526: g_main_loop_run (gmain.c:2799)
==21886==    by 0x7329E18: gtk_main (gtkmain.c:1219)
==21886==    by 0x809292C: run_inner_loop (main.c:233)
==21886==    by 0x7329F80: gtk_main (gtkmain.c:2339)
==21886==    by 0x8092862: main (main.c:333)

Anyhow, I'll look into it.

Thanks,

Ben.