pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[misc 01/18] friedman: Fix GCC warning about uninitialized fr.w.


From: Ben Pfaff
Subject: [misc 01/18] friedman: Fix GCC warning about uninitialized fr.w.
Date: Sat, 11 Dec 2010 22:19:55 -0800

On my machine GCC 4.4 complains:
friedman.c: In function ‘friedman_execute’:
friedman.c:106: warning: ‘fr.w’ may be used uninitialized in this function

This appears to be because GCC can't see that the assignment to fr.w and
its later use (in show_sig_box()) both have the same condition.  At any
rate, this commit suppresses the warning by always initializing fr.w.
---
 src/language/stats/friedman.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/language/stats/friedman.c b/src/language/stats/friedman.c
index 9711167..9950543 100644
--- a/src/language/stats/friedman.c
+++ b/src/language/stats/friedman.c
@@ -202,6 +202,8 @@ friedman_execute (const struct dataset *ds,
       fr.w /= pow2 (fr.cc) * (pow3 (ost->n_vars) - ost->n_vars)
        - fr.cc * sigma_t;
     }
+  else
+    fr.w = SYSMIS;
 
   show_ranks_box (ost, &fr);
   show_sig_box (ost, &fr);
-- 
1.7.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]