pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Debugging case refs


From: John Darrington
Subject: Re: Debugging case refs
Date: Fri, 22 Oct 2010 17:07:22 +0000
User-agent: Mutt/1.5.18 (2008-05-17)

OK.  How about this new patch, which keeps the switch entirely within
case.c

J'


On Mon, Oct 04, 2010 at 12:42:03PM -0700, Ben Pfaff wrote:
     John Darrington <address@hidden> writes:
     
     > It's almost impossible to track down memory leaks when ref counted
     > objects are involved.  I'm proposing this patch to case.[ch] which
     > allows a preprocessor option to be set redefining case_ref and 
case_unref 
     > to unconditionally copy and destroy cases respectively.  
     >
     > It would be easier to use if we could put the switch entirely inside 
case.c,
     > since almost everything depends upon case.h -- but we could only do that
     > if we sacrificed the benefits of the inline functions.
     
     I think that this is valuable enough that we should move it into
     case.c.  I'm half-inclined to think that we should make it
     configurable at runtime instead of at compilation time, but once
     it is isolated in case.c this is less important because only a
     single file will have to be recompiled if the setting changes.
     -- 
     Ben Pfaff 
     http://benpfaff.org

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.


Attachment: caseref2.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]