[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [i18n 0/6] Fixes for recode_string().
|
From: |
John Darrington |
|
Subject: |
Re: [i18n 0/6] Fixes for recode_string(). |
|
Date: |
Tue, 21 Sep 2010 14:30:32 +0000 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Sep 20, 2010 at 10:50:20PM -0700, Ben Pfaff wrote:
When I was looking at other code tonight, I noticed some problems
with the recode_string() function. This series fixes them up.
I don't see any problems with any of these patches, although I haven't
actually tried them.
I suspect that the testsuite does not exercise this function all
that well, but it does pass with these changes.
So far as I'm aware, there are no tests whatsoever for this function.
We should add some and do some coverage analysis too.
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.
signature.asc
Description: Digital signature
- [i18n 0/6] Fixes for recode_string()., Ben Pfaff, 2010/09/21
- [i18n 3/6] i18n: Ensure that every recoding starts from the initial shift state., Ben Pfaff, 2010/09/21
- [i18n 4/6] i18n: Properly restart conversion when output buffer overflows., Ben Pfaff, 2010/09/21
- [i18n 5/6] i18n: Refactor for simplicity., Ben Pfaff, 2010/09/21
- [i18n 1/6] i18n: Lightly reformat comments to better resemble other files., Ben Pfaff, 2010/09/21
- [i18n 6/6] i18n: Handle EINVAL more gracefully., Ben Pfaff, 2010/09/21
- [i18n 2/6] i18n: Avoid memory leak when create_iconv() fails., Ben Pfaff, 2010/09/21
- Re: [i18n 0/6] Fixes for recode_string().,
John Darrington <=