Re: commit 1dfc6b1f6ed81c2b58b5beca09d7f7ab903c8ad8

[Ben Pfaff]

John Darrington <address@hidden> writes:

>       hmap-test: Disable tests that GCC 4.3 miscompiles.
>       Commit ac58b3c51 "Avoid bug in GCC 4.3 in hmap-test." attempted to work 
> around a bug in GCC 4.3 that was causing test failures in hmap-test. 
> Unfortunately, the problem has started resurfacing again, probably due to 
> changes elsewhere, so this commit simply disables the tests in question when 
> PSPP is built with GCC 4.3. 
>
>
> Instead of simply ignoring this test, I suggest that it returns 77 if the 
> offending 
> compiler version is detected.  That way, there will be a warning that the 
> test was not run.

You are right, that is better.  I pushed this change.
-- 
"To the engineer, the world is a toy box full of sub-optimized and
 feature-poor toys."
--Scott Adams