[patch #6801] Sign Test

[Ben Pfaff]

Follow-up Comment #1, patch #6801 (project pspp):

Looks good.  A few comments:

* In the documentation, could you refer to subcommand names in all-capitals
(e.g. WILCOXON, SIGN).  It's the convention that I've tried to use throughout
the manual; it may not be the best convention, but it's best to be consistent
about it at least, I think.

* In sign.h, it is pretty odd to have some declarations outside the main
#ifndef...#endif block.  Could you move them inside it?

* Also in that header, the "enum mv_class;" forward declaration of an enum is
a GCC extension.  Instead of doing that, could you insert #include
<data/missing-values.h>?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6801>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/