pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6650] one pass covariance algorithm


From: John Darrington
Subject: [patch #6650] one pass covariance algorithm
Date: Thu, 16 Oct 2008 06:56:29 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.15) Gecko/20080612 Iceweasel/2.0.0.15 (Debian-2.0.0.15-0etch1)

Follow-up Comment #7, patch #6650 (project pspp):

It looks good.

But I think it can be simplified by having the 
struct hsh_table , struct moments1, and the struct variable array (and
possibly other things) all encapsulated into one single struct which gets
passed to covariance_accumulator_to_matrix, covariance_create and
covariance_acculumlate.  

This would make the calling code (such as glm.q) a lot simpler.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6650>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]