[patch #6358] Text import

[John Darrington]

Follow-up Comment #22, patch #6358 (project pspp):

Looks all very good to me.

1. Instead of 
  gtk_button_new_with_label ("Reset");
can you use
 gtk_button_new_from_stock ("pspp-stock-reset");

2. gtk_window_set_title (GTK_WINDOW (a->assistant), "Importing Textual Data")
needs the string to use _("...")

3. I'm guessing that the first element of 
static const struct separator separators[] =
  {
    {"space", ' '},
    {"tab", 't'},
    ...}
is what get's used to display the strings in the Choose Seperators page. 
Therefore, shouldn't we use N_("") for the first element?



Some other minor gnits:

* Change 2007 to 2008 in the copyright notices.
* The #include directives in text-data-import-dialog.h are not necessary.
* The first arg to apply_dict can be const.
* A number of places which use xstrdup, we can use g_strdup instead.
Similarly they can be freed with g_free.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6358>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/