[patch #6302] Fix bugs in GET DATA/TYPE=TXT.

[Ben Pfaff]

Update of patch #6302 (project pspp):

                  Status:   Ready For Test/Review => In Progress            
             Assigned to:                    None => blp                    
                 Summary: Implement GET DATA/TYPE=TXT. => Fix bugs in GET
DATA/TYPE=TXT.

    _______________________________________________________

Follow-up Comment #6:

I checked this in.  I'm changing the title of the patch to reflect open
issues that have been pointed out.  I will deal with them as soon as I can. 
(I didn't consider them important enough to postpone checking this in, hope
you guys agree.)

>1. I suggest that you put a @xref from the DATA LIST section to 
>the GET DATA /TYPE=TXT section of the manual. 

Done.

>2. The error messages could be kinder if I try to use GET DATA, but
>forget a mandatory subcommand. Currently, I get simply "Syntax error
>expecting `/' at end of command." but appending a / to the end of the
>command doesn't improve things.

I am not sure what you envision should be done here.  At any rate, I
adjusted the code so that a command such as
  get data/type=txt/file=inline/qualifier='x'/.
now prompts the error message
  error: GET DATA: Syntax error expecting VARIABLES at end of command.
This does seem to be an improvement.

>I hope that /etc/passwd entry doesn't come from any important
>machine!

You can rest assured that the data in it is fake and truncated data
liberally mixed (and I use shadow passwords anyhow).


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6302>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/