Re: PSPP & PSPPIRE running as native windows applications.

[John Darrington]

Thanks for reporting this. I've checked in some changes which should
address some of these issues. 


     mingw does
     not export functions in .exes by default; in windows we have to prefix
     functions, required by glade, with G_MODULE_EXPORT. 

So far as I'm aware, there are only two such functions.  I've added
this prefix to both of  them. 


     Index: data-editor.c
     ===================================================================
     RCS file: /sources/pspp/pspp/src/ui/gui/data-editor.c,v
     retrieving revision 1.16
     diff -r1.16 data-editor.c
     137a138,150
     >   g_assert(vs); //Traps a possible bug in win32 build, see

I've added this assertion.

    To ensure these
    functions are exported in the cross-compiled psppire.exe I also had to
    change the Makefile to include
     dlltool -e psppire.exp src/ui/gui/*.o

I suppose there's a way to get automake/libtool to emit this command,
but I'm not sure how to do it.

   //You make have to also add -Wl,--export-dynamic to GLADE_LIBS

As I understand it, using G_MODULE_EXPORT should mean that this is
unnecessary.   Withoutt it,you may have seen warnings because it was
trying to connect to signal handlers specified in the .glade files.
These handlers were redundant, and I've removed them now.

Three of the tests were failing merely due to whitespace differences.
I've fixed these three tests.

The differences shown in the  RANK test is interesting.  I suspect the
problem is at src/language/stats/rank.q:701

  snprintf(func_abb, 4, "%s", function_name[f]);

according to my man page " The functions snprintf() and vsnprintf() do
not write more than size bytes (including the trailing '\0').", but
your version does not seem to include the trailing null in the size,
so we're seeing one more character.  Perhaps you should report that
to the maintainer of your C library.  Alternatively perhaps we should
be using gnulib/autoconf to deal with broken implementations.


Anyway, let me know if the changes I've made have improved matters at
all.


J'




-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature