Re: [patch #5583] NPAR TESTS

[John Darrington]

On Sat, Nov 25, 2006 at 01:36:39AM +0000, Ben Pfaff wrote:
     
     Follow-up Comment #1, patch #5583 (project pspp):
     
     Have you checked out the algorithms described on spss.com against what SPSS
     Statistical Algorithms says?  The latter might be dated; who
     knows.

I was actually refering to the pages downloaded from spss.com  So far
as I'm aware, they are identical to those from SPSS Statistical
Algorithms.  I'll check the copy in the UWA library next week to make
sure.

     In value_dup, I'd prefer to calculate the size as MIN(width,
     sizeof *val).

This would give the wrong answer, since if width is zero, then the
size should be 8.
     
     In compare_var_index, please use less-than and greater-than to figure out 
the
     comparison result; if we ever change the `index' member to an unsigned type
     (which would make a lot of sense), we'll really appreciate not having to 
hunt
     down this bug.

OK.
     
     I didn't look very closely at the new files you introduced.  I'll assume 
that
     they do the right thing.

"Right thing" is somewhat subjective.  But I thought about it fairly
carefully.  I think it'll make it easy to add new subcommands to NPAR
TEST, at least from the parsing point of view.   It also fits in with
a general idea I have to seperate the parsing of commands from their
execution, which I'll talk about later. 

J'
     

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

pgp_XS3aUe12t.pgp
Description: PGP signature