pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unimplemented commands


From: Ben Pfaff
Subject: Re: Unimplemented commands
Date: Sun, 15 Oct 2006 19:40:19 -0700
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

John Darrington <address@hidden> writes:

> Currently, commands listed in src/language/command.def as UNIMPL_CMD
> are silently ignored.  Is this behaviour how we really want it?

No.  I checked this in:

Index: command.c
===================================================================
RCS file: /cvsroot/pspp/pspp/src/language/command.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -p -u -p -r1.15 -r1.16
--- command.c   14 Oct 2006 00:25:20 -0000      1.15
+++ command.c   16 Oct 2006 02:39:32 -0000      1.16
@@ -178,8 +178,11 @@ do_parse_command (enum cmd_state state)
   command = parse_command_name ();
   if (command == NULL)
     return CMD_FAILURE;
-  else if (command->function == NULL)
-    return CMD_NOT_IMPLEMENTED;
+  else if (command->function == NULL) 
+    {
+      msg (SE, _("%s is unimplemented."), command->name);
+      return CMD_NOT_IMPLEMENTED; 
+    }
   else if ((command->flags & F_TESTING) && !get_testing_mode ()) 
     {
       msg (SE, _("%s may be used only in testing mode."), command->name);

Thanks for pointing this out.
-- 
A bicycle is one of the world's beautiful machines, beautiful machines
are art, and art is civilisation, good living, and balm to the soul.
--Elisa Francesca Roselli




reply via email to

[Prev in Thread] Current Thread [Next in Thread]