pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: file-handles


From: Ben Pfaff
Subject: Re: file-handles
Date: Sun, 22 Jan 2006 16:58:52 -0800
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

John Darrington <address@hidden> writes:

> Frankly, the only reason the GUI needs to bother with file_handles, is
> that it's currently the only way to call sfm_open_{reader,writer}.
> I'd be happier to add a function to these modules, which takes a
> filename instead of  a file_handle (and the same for pfm_open).  Then
> I don't need to use file handles at all.
>
> Do you think that would be a better solution?

It sounds reasonable too.  You'll need to replace a lot of calls
to fh_get_filename() by a saved copy of the filename, but that
might actually qualify as a clean-up.  Do make sure to preserve
the pairing of fh_open() and fh_close(), even in error
cases.
-- 
On Perl: "It's as if H.P. Lovecraft, returned from the dead and speaking by
seance to Larry Wall, designed a language both elegant and terrifying for his
Elder Things to write programs in, and forgot that the Shoggoths didn't turn
out quite so well in the long run." --Matt Olson




reply via email to

[Prev in Thread] Current Thread [Next in Thread]