[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v1.6.2-213-g19199
From: |
Ben Pfaff |
Subject: |
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v1.6.2-213-g1919945e0 |
Date: |
Sun, 5 Mar 2023 14:42:20 -0500 (EST) |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".
The branch, master has been updated
via 1919945e08f6c44a13ed90e3959b3aa4f176b5e6 (commit)
via 5254d0860f9d48f8404e50adb1b1cba1ba2e4506 (commit)
via 36bba0ffbec3b8432d4ececb720bf033053f5d46 (commit)
via 386de605e587854f3640b3998b5cc621f263272a (commit)
via 9cf53942f5772eb7b928955f6e7e0ba950381bfc (commit)
via 66f75a6ba7c0e51f41ddba7b1c82c6e6b5279ed1 (commit)
via 1dcdba517fbb5c99c37e0a03275325f256975c7c (commit)
via afea472df1680beefe6d2b693f3c954fde3b3313 (commit)
via 039238c6fd5cc2310e0d6b40358f29347cfcbce7 (commit)
via 69bd50b717021786aedf541394a150b72e4e9a7c (commit)
via e0b27f6f4cde2d52508db337c76ea81a8ca8ee79 (commit)
via 2891092322c530609ebfc132b6d0e62f515946db (commit)
via 8a27e591b9bf45a9c7b6f0cb3bfa727382c4958c (commit)
via 4b0fcb170ee937ea28a51fa4fed37c012629a3ab (commit)
via 54b3aa8432383287c75b9baf954b7bf887126a0c (commit)
via 6953fd7f0ef58595a14548c4262f0e4c65b8939a (commit)
via b7968b37a3825943816f9c262d4b2979397f6a83 (commit)
from 1a75df68d6fc286437fc7e0fb6413d3ffa221094 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 1919945e08f6c44a13ed90e3959b3aa4f176b5e6
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sun Mar 5 11:14:45 2023 -0800
case-map: Make creating a case_map destroy the stage.
This fit the usage model in every case in practice.
commit 5254d0860f9d48f8404e50adb1b1cba1ba2e4506
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sun Mar 5 11:08:00 2023 -0800
dataset: Replace 'compactor' by a translating casewriter.
commit 36bba0ffbec3b8432d4ececb720bf033053f5d46
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sun Mar 5 11:07:38 2023 -0800
case-map: Identity map is only when there are no changes at all.
case_map_stage_get_case_map() called a mapping an identity map when no
data was reordered, which left the possibility that data was removed from
the end would be called an identity map. This seems like a bad idea, so
this commit tightens the criteria.
This is a bigger than necessary change that also avoids per-variable
malloc()s that weren't really needed.
This might be a bug fix. I haven't identified a particular bug that
it fixes.
commit 386de605e587854f3640b3998b5cc621f263272a
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sun Mar 5 11:04:29 2023 -0800
case-map: Optimize case_map_create_output_translator() for no-op case.
commit 9cf53942f5772eb7b928955f6e7e0ba950381bfc
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sat Mar 4 22:26:03 2023 -0800
dictionary: Get rid of case indexes.
Dictionary index (the index into the variables in the dictionary)
and case index (the index into struct ccase for a variable from
the dictionary) have always been independent, but they are
*usually* the same. It is much cleaner to have an invariant
that they are *always* the same. This commit makes that the case.
commit 66f75a6ba7c0e51f41ddba7b1c82c6e6b5279ed1
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sun Mar 5 09:23:53 2023 -0800
dictionary: Short-circuit no-op case in dict_reorder_var().
commit 1dcdba517fbb5c99c37e0a03275325f256975c7c
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sat Mar 4 19:06:12 2023 -0800
dictionary: Always compact immediately upon deletion of a variable.
With this change, the dictionary has a new invariant that the case_indexes
are always a permutation of [0,N) where N is the number of variables in
the dictionary. Most commonly, the case_indexes are the same as the
dict_indexes, but reordering the dictionary can permute them.
commit afea472df1680beefe6d2b693f3c954fde3b3313
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sat Mar 4 08:31:29 2023 -0800
pc+-file-reader: Drop unneeded struct member.
commit 039238c6fd5cc2310e0d6b40358f29347cfcbce7
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri Mar 3 18:45:00 2023 -0800
dictionary: Get rid of "internal var" concept.
It's nasty and doesn't conform to the usual invariants.
commit 69bd50b717021786aedf541394a150b72e4e9a7c
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri Mar 3 17:56:15 2023 -0800
case-map: Simplify case_map_stage_get_case_map().
A caseproto can't contain -1s anymore, so don't look for them.
commit e0b27f6f4cde2d52508db337c76ea81a8ca8ee79
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri Mar 3 17:55:12 2023 -0800
case-map: Remove buggy and unused case_map_clone().
The xmemdup() in the implementation copied 'old->proto' to 'new->map',
which can't possibly work. We could fix it but it wasn't used anyway.
commit 2891092322c530609ebfc132b6d0e62f515946db
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri Mar 3 17:31:36 2023 -0800
dictionary: Get rid of next_value_idx.
At this point, it was always the number of variables in the dictionary.
commit 8a27e591b9bf45a9c7b6f0cb3bfa727382c4958c
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri Mar 3 16:49:33 2023 -0800
caseproto: Disallow -1 elements in caseprotos.
This is a stronger invariant that should make PSPP code easier to
understand.
It required updating dict_get_proto() to avoid intermediate stages in
which a -1 appeared as a width.
commit 4b0fcb170ee937ea28a51fa4fed37c012629a3ab
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri Mar 3 16:43:52 2023 -0800
caseproto: Allocate base struct and widths separately.
This will allow constructing a caseproto from a passed-in array
without copying it.
commit 54b3aa8432383287c75b9baf954b7bf887126a0c
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri Mar 3 16:43:59 2023 -0800
dataset: Before deleting variables, make sure new values are added.
This fixes a crash reported privately by knassen(at)chartermi.net.
commit 6953fd7f0ef58595a14548c4262f0e4c65b8939a
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Thu Mar 2 14:25:30 2023 -0800
caseinit: Introduce new caseinit_translate_casereader_to_init_vars().
commit b7968b37a3825943816f9c262d4b2979397f6a83
Author: Ben Pfaff <blp@cs.stanford.edu>
Date: Sun Mar 5 09:24:30 2023 -0800
Makefiles: Make a couple of targets build more quietly.
-----------------------------------------------------------------------
Summary of changes:
src/data/case-map.c | 159 +++++++-----------
src/data/case-map.h | 7 +-
src/data/case.c | 24 +--
src/data/caseinit.c | 95 +++++++++--
src/data/caseinit.h | 9 +-
src/data/caseproto.c | 125 +++++++-------
src/data/caseproto.h | 26 ++-
src/data/casereader.c | 4 +-
src/data/casewriter.c | 4 +-
src/data/csv-file-writer.c | 2 +-
src/data/dataset-writer.c | 17 +-
src/data/dataset.c | 115 +++++++------
src/data/dataset.h | 1 +
src/data/datasheet.c | 6 +
src/data/dictionary.c | 245 +++++-----------------------
src/data/dictionary.h | 15 +-
src/data/pc+-file-reader.c | 35 ++--
src/data/por-file-writer.c | 2 +-
src/data/subcase.c | 6 +-
src/data/sys-file-private.c | 2 +-
src/data/sys-file-reader.c | 1 -
src/data/transformations.c | 13 ++
src/data/transformations.h | 1 +
src/data/vardict.h | 7 -
src/data/variable.c | 11 --
src/data/variable.h | 1 -
src/language/commands/aggregate.c | 11 +-
src/language/commands/autorecode.c | 4 +-
src/language/commands/combine-files.c | 1 -
src/language/commands/data-list.c | 4 +-
src/language/commands/examine.c | 2 +-
src/language/commands/get-data.c | 4 +-
src/language/commands/get.c | 4 +-
src/language/commands/inpt-pgm.c | 5 +-
src/language/commands/jonckheere-terpstra.c | 2 +-
src/language/commands/rank.c | 4 +-
src/language/commands/roc.c | 2 +-
src/language/commands/save-translate.c | 7 +-
src/language/commands/save.c | 7 +-
src/language/commands/sort-variables.c | 3 +-
src/language/commands/wilcoxon.c | 20 +--
src/language/commands/wilcoxon.h | 3 +
src/libpspp/automake.mk | 2 +-
src/math/order-stats.c | 4 +-
src/ui/gui/automake.mk | 4 +-
src/ui/gui/find-dialog.c | 2 +-
src/ui/gui/marshaller-list | 2 +
src/ui/gui/psppire-data-sheet.c | 2 +-
src/ui/gui/psppire-data-store.c | 52 +++---
src/ui/gui/psppire-data-store.h | 3 +-
src/ui/gui/psppire-data-window.c | 2 +-
src/ui/gui/psppire-dict.c | 73 ++++-----
src/ui/gui/psppire-dict.h | 5 -
tests/language/commands/delete-variables.at | 19 +++
utilities/pspp-convert.c | 5 +
55 files changed, 530 insertions(+), 661 deletions(-)
hooks/post-receive
--
GNU PSPP
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v1.6.2-213-g1919945e0,
Ben Pfaff <=