[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-329-gace5f
From: |
Ben Pfaff |
Subject: |
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-329-gace5fed |
Date: |
Sun, 19 Aug 2012 18:42:19 +0000 |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".
The branch, master has been updated
via ace5fed0c507901119c906dc72f1c058bbb6f587 (commit)
via 6be7e7732a1f1901daf439fd1c96c4353af0da17 (commit)
via ce2b9742d02e7619a6bca2102c4985e5828cdcc9 (commit)
via c3f06028950f69cd695062fe01a64ba73e164b3e (commit)
via 8de0368d4ec642662fdff99aefc5fbf19ce5afc9 (commit)
via ead7b2eb3c1d47a7a33b0a545b2e8a4d620e654a (commit)
from badbcb0f72b9f549abb3aef25ea9cb387a45c79a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ace5fed0c507901119c906dc72f1c058bbb6f587
Author: Ben Pfaff <address@hidden>
Date: Sun Aug 19 11:36:16 2012 -0700
missing-val-dialog: Convert to a GObject.
commit 6be7e7732a1f1901daf439fd1c96c4353af0da17
Author: Ben Pfaff <address@hidden>
Date: Sun Aug 19 11:41:25 2012 -0700
missing-val-dialog: Avoid destroying uninitialized data.
If text_to_value() fails for low_val, then this code would still
destroy high_val, even though high_val hadn't been initialized,
thus accessing indeterminate data.
This also eliminates some redundancy in the code.
commit ce2b9742d02e7619a6bca2102c4985e5828cdcc9
Author: Ben Pfaff <address@hidden>
Date: Sat Aug 18 15:31:09 2012 -0700
gui: Rename var-sheet-dialogs.ui to missing-val-dialog.ui.
The msising value dialog is the only dialog left in this UI file.
commit c3f06028950f69cd695062fe01a64ba73e164b3e
Author: Ben Pfaff <address@hidden>
Date: Sun Aug 19 10:30:36 2012 -0700
psppire-dialog: Add "acceptable" predicate.
PsppireDialog already has a validity predicate that allows a dialog
to easily disable "OK" and other buttons when the dialog has not
yet been completely filled. It should usually be obvious to the
user why this is the case.
The upcoming GObjectification of the missing value dialog calls for
a different kind of predicate, one where the reason is not obvious
to the user (typically because he has just made a typo or does not
understand a variable's format). In this case, the user needs more
feedback, such as a message explaining the problem.
This commit therefore introduces a second kind of predicate, the
"accept" predicate. This predicate is only checked when the user
clicks on the "OK" button.
commit 8de0368d4ec642662fdff99aefc5fbf19ce5afc9
Author: Ben Pfaff <address@hidden>
Date: Sun Aug 19 11:36:42 2012 -0700
val-labs-dialog, var-type-dialog: Make these dialogs modal.
I missed this in the initial conversion.
commit ead7b2eb3c1d47a7a33b0a545b2e8a4d620e654a
Author: Ben Pfaff <address@hidden>
Date: Sun Aug 19 10:30:53 2012 -0700
val-labs-dialog: Remove unused 'window' member.
-----------------------------------------------------------------------
Summary of changes:
src/ui/gui/automake.mk | 2 +-
src/ui/gui/missing-val-dialog.c | 326 +++++++++++++++++++++++++++-----------
src/ui/gui/missing-val-dialog.h | 55 +++++--
src/ui/gui/missing-val-dialog.ui | 232 +++++++++++++++++++++++++++
src/ui/gui/psppire-buttonbox.c | 20 ++-
src/ui/gui/psppire-dialog.c | 30 ++++
src/ui/gui/psppire-dialog.h | 6 +
src/ui/gui/psppire-var-sheet.c | 58 +++----
src/ui/gui/psppire-var-sheet.h | 2 -
src/ui/gui/val-labs-dialog.c | 1 +
src/ui/gui/val-labs-dialog.h | 2 -
src/ui/gui/var-sheet-dialogs.ui | 284 ---------------------------------
src/ui/gui/var-type-dialog.c | 1 +
13 files changed, 585 insertions(+), 434 deletions(-)
create mode 100644 src/ui/gui/missing-val-dialog.ui
delete mode 100644 src/ui/gui/var-sheet-dialogs.ui
hooks/post-receive
--
GNU PSPP
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-329-gace5fed,
Ben Pfaff <=