[Pspp-commits] [SCM] GNU PSPP branch, value-rep, updated. v0.6.1-584-gbae1ef3

[Ben Pfaff]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, value-rep has been updated
       via  bae1ef34a8f30deacd6d3239088ded80790d9fd9 (commit)
       via  9ea11da4f80af6aeb94ff16abdb302c8e2a99d09 (commit)
       via  1559a32f9a572a6ae2f189857bc067d2d3ef49ad (commit)
       via  2d037dc0c3cc414fb1923bfb83915befad21c2be (commit)
       via  f8ebf552ccea07b103e5d93d0b1ced2120a4589b (commit)
       via  5d9f0488561945220ad34da2096f236cb24fdb8f (commit)
       via  829f1694dbd5393bea14655f4677793359d7915c (commit)
       via  5b013578f284a5e289696d16cd223cfc485ed154 (commit)
       via  fd03356e4f9b1e50d7ded536ef6272ca9f898e5e (commit)
       via  079afd0af376878293432747fcbd32acf77c5f29 (commit)
       via  298e4c87e825ef847623f1e2bb6a336c5ab3ec94 (commit)
       via  3ad8f0fbcb5563a05a83cea6b281c7fc168bfdb4 (commit)
       via  6e5f391683ad76b5cd91f5d455f5fc0ec5afcd3c (commit)
       via  e621aaf5c78214d23ca8281c34b15ab18082dd6a (commit)
       via  0a9821bcee8b4fe31e0f98384ea44051700f1baa (commit)
       via  c8014102de3dc7854a30c3c84af680a374654697 (commit)
       via  0c6f5a686b3aad8990b4036807b43bf799c77095 (commit)
       via  b3bef06d2a15c730a903a3102ad6e55fd304eb91 (commit)
       via  0bbf2ab753530a6397391a8790d6ff71b506d951 (commit)
       via  d8e7fa6cb3981377d8f7e51a0f94b0059a545622 (commit)
       via  a601226b787acb679e041664ddf3527152c14355 (commit)
      from  f3e9fcee702b4b6d0633ad9568f4ae660a3fc294 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bae1ef34a8f30deacd6d3239088ded80790d9fd9
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:48:50 2009 -0700

    PSPPIRE: Fix behavior of data store when columns are resized.

commit 9ea11da4f80af6aeb94ff16abdb302c8e2a99d09
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:48:26 2009 -0700

    datasheet: New function datasheet_resize_column().

commit 1559a32f9a572a6ae2f189857bc067d2d3ef49ad
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 06:04:43 2009 -0700

    sparse-xarray: New function sparse_xarray_copy().

commit 2d037dc0c3cc414fb1923bfb83915befad21c2be
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:42:23 2009 -0700

    model-checker: Add command-line parser for model checking options.
    
    This adds a parser for command-line options to configure a set of
    mc_options for running the model checker.  It is used by an upcoming test
    for the sparse_xarray.  It might also make sense to break the datasheet
    tests out of PSPP into a separate program using this parser.

commit f8ebf552ccea07b103e5d93d0b1ced2120a4589b
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:39:03 2009 -0700

    Implement new command-line argument parser.
    
    glibc has two option parsers, but neither one of them feels quite
    right:
    
      - getopt_long is simple, but not modular, in that there is no
        easy way to make it accept multiple collections of options
        supported by different modules.
    
      - argp is more sophisticated and more complete, and hence more
        complex.  It still lacks one important feature for
        modularity: there is no straightforward way for option groups
        that are implemented independently to have separate auxiliary
        data,
    
    The parser implemented in this commit is meant to be simple and
    modular.  It is based internally on getopt_long.
    
    The initial use for this option parser is for an upcoming commit of a test
    program that has some of its own options and some from the model checker,
    but it should also be appropriate for PSPP and PSPPIRE if anyone wants to
    adapt them to use it.

commit 5d9f0488561945220ad34da2096f236cb24fdb8f
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 22:30:02 2009 -0700

    model-checker: Don't discard error states.
    
    Even if a state with an error is a duplicate, we don't want to discard it,
    because then we lose information about bugs.

commit 829f1694dbd5393bea14655f4677793359d7915c
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 22:27:05 2009 -0700

    model-checker: Revise advice on checking for duplicates.
    
    Until now the documentation on the model checker has advised checking for
    a duplicate state before checking for consistency, but in fact this can
    cause bugs to be missed if only some paths to a given state yield
    incorrect results.  So revise the advice to check for consistency before
    checking for a duplicate state.

commit 5b013578f284a5e289696d16cd223cfc485ed154
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 22:20:42 2009 -0700

    model-checker: Add more progress functions.
    
    The model checker supports "progress functions" that report the current
    status of the model checking run.  Until now the implementation only
    exported a single progress function that printed a line of dots across
    stderr.  This commit moves the "fancy" progress function that was
    previously part of the PSPP language code into the model checker itself
    and adds an even more verbose progress function as well.

commit fd03356e4f9b1e50d7ded536ef6272ca9f898e5e
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 22:33:48 2009 -0700

    model-checker: Move summary printing function into model checker.
    
    There is no reason that the model checker itself should not be able to
    print a summary of its results.  Until now, this code was buried in the
    PSPP language code, but the model checker itself is a better place for it.

commit 079afd0af376878293432747fcbd32acf77c5f29
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 21:09:12 2009 -0700

    model-checker: Kill dependencies and move back to libpspp.
    
    Commit 95b074ff3 "Moved the datasheet testing code out of
    src/{libspp,data}" moved the model-checker implementation from libpspp
    into language/tests because it depended on math/moments.h and
    data/val-type.h, which violates the dependency structure of the PSPP
    libraries.
    
    However, now I want to use the model checker in a test that should not
    need to use anything from language/tests, so this commit eliminates these
    dependencies and moves the model checker back to src/libpspp.

commit 298e4c87e825ef847623f1e2bb6a336c5ab3ec94
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 20:44:00 2009 -0700

    Move sparse-xarray and its dependencies to libpspp.

commit 3ad8f0fbcb5563a05a83cea6b281c7fc168bfdb4
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 20:35:26 2009 -0700

    Make dictionary var resize callback argument easier for me to understand.
    
    Previously, the third argument to the var_resized callback in struct
    dict_callbacks indicated the delta by which the variable's size changed.
    I have always found this confusing (to get the old width, do we add the
    delta to the new width or subtract it?), so this commit changes that
    argument to simply be the old width.

commit 6e5f391683ad76b5cd91f5d455f5fc0ec5afcd3c
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 21:53:07 2009 -0700

    sparse-array: Simplify code slightly.
    
    Instead of checking whether the key is in range in each caller of
    find_leaf_node, do it in find_leaf_node itself.  This also allows checking
    the cache before checking whether the key is in range, which might be an
    optimization.

commit e621aaf5c78214d23ca8281c34b15ab18082dd6a
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:52:03 2009 -0700

    sparse-array: Improve iteration interface.
    
    The sparse_array_scan function only supports iteration in the forward
    direction and its interface is somewhat awkward.  This commit replaces it
    by four new functions that allow iteration in both forward and reverse
    directions and have a more conventional interface.

commit 0a9821bcee8b4fe31e0f98384ea44051700f1baa
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:51:54 2009 -0700

    sparse-array: Use __builtin_ctzl on GCC 4.0 or later, as an optimization.
    
    This should be a worthwhile optimization in many cases, because
    __builtin_ctzl compiles to a single machine instruction on x86, whereas
    the generic implementation compiles to several.

commit c8014102de3dc7854a30c3c84af680a374654697
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 19:31:16 2009 -0700

    range-set: New functions range_set_last and range_set_prev.
    
    These are useful for iterating through a range set in reverse order.

commit 0c6f5a686b3aad8990b4036807b43bf799c77095
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 20:27:54 2009 -0700

    range-set: Add new function range_set_scan().

commit b3bef06d2a15c730a903a3102ad6e55fd304eb91
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 20:27:10 2009 -0700

    range-set: Inline some simple functions.
    
    Some of the range-set functions are very simple and worth inlining, so
    move the definitions of those functions into range-set.h.  This required
    moving the definition of struct range_set and struct range_set_node into
    the header.  Some of the functions used internally by those functions had
    to be moved too, and renamed as well since for internal use in range-set.c
    their names did not respect the namespace.

commit 0bbf2ab753530a6397391a8790d6ff71b506d951
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 20:14:52 2009 -0700

    range-set: Add test coverage for range_set_destroy(NULL).
    
    "gcov -b" showed that range_set_destroy() was never called with a NULL
    argument.  There's no reason not to test that too (although of course it
    is unlikely to be broken).

commit d8e7fa6cb3981377d8f7e51a0f94b0059a545622
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 22:10:50 2009 -0700

    tmpfile: Tolerate n == 0 in tmpfile_read and tmpfile_write.
    
    POSIX requires that fread and fwrite return 0 if either of their size
    arguments is 0.  We were treating this as a failure case, but in fact
    it should be treated as success since we did in fact successfully read or
    write 0 bytes.

commit a601226b787acb679e041664ddf3527152c14355
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:46:01 2009 -0700

    datasheet: Drop false dependency on md4.h.
    
    datasheet-check.c doesn't use anything from md4.h, so there's no point in
    including it.

-----------------------------------------------------------------------

Summary of changes:
 Smake                                           |    1 +
 src/data/automake.mk                            |    4 -
 src/data/case-tmpfile.c                         |    2 +-
 src/data/datasheet.c                            |  278 ++++++++---
 src/data/datasheet.h                            |    4 +
 src/data/dictionary.c                           |    5 +-
 src/data/sparse-xarray.c                        |  323 ------------
 src/data/vardict.h                              |    4 +-
 src/data/variable.c                             |    2 +-
 src/language/tests/automake.mk                  |    2 -
 src/language/tests/check-model.q                |   79 +---
 src/language/tests/datasheet-check.c            |    3 +-
 src/libpspp/argv-parser.c                       |  182 +++++++
 src/libpspp/argv-parser.h                       |   58 +++
 src/libpspp/automake.mk                         |    8 +
 src/{language/tests => libpspp}/model-checker.c |  312 +++++++++++-
 src/{language/tests => libpspp}/model-checker.h |   33 +-
 src/libpspp/range-set.c                         |  162 ++----
 src/libpspp/range-set.h                         |  180 +++++++-
 src/libpspp/sparse-array.c                      |  329 +++++++++---
 src/libpspp/sparse-array.h                      |   13 +-
 src/libpspp/sparse-xarray.c                     |  578 +++++++++++++++++++++
 src/{data => libpspp}/sparse-xarray.h           |   45 +-
 src/{data => libpspp}/tmpfile.c                 |    6 +-
 src/{data => libpspp}/tmpfile.h                 |    6 +-
 src/ui/gui/psppire-data-store.c                 |   38 ++-
 src/ui/gui/psppire-dict.c                       |    4 +-
 tests/automake.mk                               |   16 +
 tests/libpspp/range-set-test.c                  |   96 ++++
 tests/libpspp/sparse-array-test.c               |   18 +-
 tests/libpspp/sparse-xarray-test.c              |  624 +++++++++++++++++++++++
 31 files changed, 2667 insertions(+), 748 deletions(-)
 delete mode 100644 src/data/sparse-xarray.c
 create mode 100644 src/libpspp/argv-parser.c
 create mode 100644 src/libpspp/argv-parser.h
 rename src/{language/tests => libpspp}/model-checker.c (80%)
 rename src/{language/tests => libpspp}/model-checker.h (95%)
 create mode 100644 src/libpspp/sparse-xarray.c
 rename src/{data => libpspp}/sparse-xarray.h (60%)
 rename src/{data => libpspp}/tmpfile.c (96%)
 rename src/{data => libpspp}/tmpfile.h (93%)
 create mode 100644 tests/libpspp/sparse-xarray-test.c


hooks/post-receive
--
GNU PSPP