Re: [PATCH] ios-dev-mmap: close the file descriptor on failure

[Jose E. Marchesi]

Hi Mohammad.

OK for both master and maint/poke-4.
Thanks.

> 2024-03-16  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
>
>       * libpoke/ios-dev-mmap.c (ios_dev_mmap_open): Close the opened
>       file, in case of error.
> ---
>  ChangeLog              | 5 +++++
>  libpoke/ios-dev-mmap.c | 3 +++
>  2 files changed, 8 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index d91bc925..1f35db05 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2024-03-16  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
> +
> +     * libpoke/ios-dev-mmap.c (ios_dev_mmap_open): Close the opened
> +     file, in case of error.
> +
>  2024-03-16  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
>  
>       * testsuite/Makefile.am (check-DEJAGNU): Set `HOST_OS' env var.
> diff --git a/libpoke/ios-dev-mmap.c b/libpoke/ios-dev-mmap.c
> index 7650b795..0763592c 100644
> --- a/libpoke/ios-dev-mmap.c
> +++ b/libpoke/ios-dev-mmap.c
> @@ -150,6 +150,7 @@ ios_dev_mmap_open (const char *handler, uint64_t flags, 
> int *error,
>    if (!dev_map)
>      goto err;
>  
> +  fd = -1;
>    memset (dev_map, 0, sizeof (struct ios_dev_mmap));
>  
>    /* Format of handler:
> @@ -285,6 +286,8 @@ ios_dev_mmap_open (const char *handler, uint64_t flags, 
> int *error,
>    return dev_map;
>  
>  err:
> +  if (fd != -1)
> +    close (fd);
>    if (dev_map)
>      free (dev_map->filename);
>    free (dev_map);