poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libpoke: fix building pvm.jitter on windows


From: Jose E. Marchesi
Subject: Re: [PATCH] libpoke: fix building pvm.jitter on windows
Date: Tue, 20 Feb 2024 20:31:48 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Hello Hannes.

This could be the right workaround, but I would prefer if it is
restricted to windows targets.  I would say it is actually necessary,
because in many targets gnulib will not #define raise with a replacement
at all.

> When trying to build libpoke on windows, you get the following error:
>
> ../../../poke.git/libpoke/pvm.jitter: In function 'pvm_execute_or_initialize':
> ../../../poke.git/libpoke/pvm.jitter:227:37: error: 
> 'pvm_specialized_instruction_opcode_rpl_raise' undeclared (first use in this 
> function); did you mean 'pvm_specialized_instruction_opcode_raise'?
>
> It's because gnulib replaces raise with rpl_raise in gl-libpoke/signal.h:
>
>  #define raise rpl_raise
>
> As far as I can tell, raise is actually not used by libpoke, so this just
> removes the define in the generated header.
>
> 2024-02-20  Hannes Domani  <ssbssa@yahoo.de>
>
>       * libpoke/pvm.jitter: Undef raise.
> ---
>  libpoke/pvm.jitter | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libpoke/pvm.jitter b/libpoke/pvm.jitter
> index 6390d353..3824236c 100644
> --- a/libpoke/pvm.jitter
> +++ b/libpoke/pvm.jitter
> @@ -247,6 +247,8 @@ late-header-c
>         type as an integer in the main stack, before branching to the
>         exception handler.  */
>  
> +#undef raise
> +
>  #define PVM_RAISE_DIRECT(EXCEPTION)                                   \
>    do                                                                  \
>    {                                                                   \



reply via email to

[Prev in Thread] Current Thread [Next in Thread]