Re: [PATCH] libpoke,poke,poked,pokefmt: add `pk_compiler' to terminal interface

[Mohammad-Reza Nabipoor]

Hi Jose.

On Wed, Nov 01, 2023 at 11:14:15PM +0100, Jose E. Marchesi wrote:
> 
> > This patch adds `pk_compiler' paramter to add terminal interface
> > function pointers.
> > Additionally it adds two new API function to set/get a user-defined
> > opaque pointer to a compiler instance.  The user can use these helper
> > functions in the terminal interface callbacks to retrieve the pointer.
> 
> The change looks generally ok, but for maintenance reasons and to ease
> review it would be better to split this into a series, with at least
> these parts:
> 
> - Patch that turns pk_print_binary into the macro PK_PRINT_BINARY.
> 
> - Patch that adds support for an user payload to be registered in
>   libpoke, i.e. internal pointer and getter/setter services.
> 
> - Patch that changes the terminal interface in libpoke to pass the
>   pk_compiler as an argument, and that changes the poke CLI, poked and
>   other users.
> 
> Would that be possible?


Sure.
Stay tuned ... :)