poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix spelling mistakes in the codebase


From: Jose E. Marchesi
Subject: Re: [PATCH] Fix spelling mistakes in the codebase
Date: Wed, 24 May 2023 09:10:08 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

Hello Constantin.

Thanks for the patch!  I have committed it on your behalf, but I
ommitted the following thunks out:

> diff --git a/libpoke/pkl-ast.h b/libpoke/pkl-ast.h
> index ebf952ba..381e441b 100644
> --- a/libpoke/pkl-ast.h
> +++ b/libpoke/pkl-ast.h
> @@ -905,7 +905,7 @@ pkl_ast_node pkl_ast_make_func_type_arg (pkl_ast ast,
>     number of elements, then BOUND is an expression that must evaluate
>     to an integer.  If the array type is bounded by size, then BOUND is
>     an expression that must evaluate to an offset.  If the array type
> -   is unbounded, then BOUND is NULL.  MAPPER, WRITER, FORMATER,
> +   is unbounded, then BOUND is NULL.  MAPPER, WRITER, FORMATTER,
>     PRINTER, CONSTRUCTOR, INTEGRATOR and BOUNDCLS are used to hold closures,
>     or PVM_NULL. The field LEX_CORRECTED is used by the transl phase, to
>     keep record of array types that have been lexically corrected; this
> @@ -917,7 +917,7 @@ pkl_ast_node pkl_ast_make_func_type_arg (pkl_ast ast,
>     ELEMS is a chain of elements, which can be
>     PKL_AST_STRUCT_TYPE_FIELD or PKL_AST_DECL nodes, potentially mixed.
>     PINNED_P is 1 if the struct is pinned, 0 otherwise.  MAPPER, WRITER
> -   CONSTRUCTOR, FORMATER, PRINTER, COMPARATOR, INTEGRATOR and
> +   CONSTRUCTOR, FORMATTER, PRINTER, COMPARATOR, INTEGRATOR and
>     DEINTEGRATOR are used to hold closures, or PVM_NULL.  ITYPE, if not
>     NULL, is an AST node with an integral type, that defines the nature
>     of this struct type as integral.
> @@ -1016,7 +1016,7 @@ struct pkl_ast_type
>        union pkl_ast_node *bound;
>        union pkl_ast_node *etype;
>        /* Uncollectable array for MAPPER, BOUNDER, WRITER, CONSTRUCTOR,
> -         INTEGRATOR, PRINTER and FORMATER.  */
> +         INTEGRATOR, PRINTER and FORMATTER.  */
>        pvm_val *closures;
>      } array;
>  
> @@ -1031,7 +1031,7 @@ struct pkl_ast_type
>        int pinned_p;
>        int union_p;
>        /* Uncollectable array for MAPPER, WRITER, CONSTRUCTOR,
> -         COMPARATOR, INTEGRATOR, DEINTEGRATOR, PRINTER, FORMATER, and
> +         COMPARATOR, INTEGRATOR, DEINTEGRATOR, PRINTER, FORMATTER, and
>           TYPIFIER.  */
>        pvm_val *closures;
>      } sct;

This is because these would require changing the names of the
corresponding struct field (formatter) and also the accessor macros.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]