Re: [PATCH v2] pkl-ast: Avoid double-frees by keeping track of frees

poke-devel

From:	Arsen Arsenović
Subject:	Re: [PATCH v2] pkl-ast: Avoid double-frees by keeping track of frees
Date:	Thu, 27 Oct 2022 18:17:33 +0200

On Thursday, 27 October 2022 18:12:45 CEST Jose E. Marchesi wrote:

> We follow the convention to use upper case for macro names, in the

> codebase.

> I would not define/use PKL_AST_NODE_FREE outside of

> pkl_ast_node_free_1. It is more clear to call it explicitly from

> pkl_ast_node_free, where the visitations (cracks me up every time

> :'D) actually come from.

OK, will change these and push.

Thanks! :)

Arsen Arsenović

signature.asc
Description: This is a digitally signed message part.

Current Thread

[Next in Thread]

[PATCH] pkl-ast: Avoid double-frees by keeping track of frees, Arsen Arsenović, 2022/10/27
- Re: [PATCH] pkl-ast: Avoid double-frees by keeping track of frees, Jose E. Marchesi, 2022/10/27
  - [PATCH v2] pkl-ast: Avoid double-frees by keeping track of frees, Arsen Arsenović, 2022/10/27
    - Re: [PATCH v2] pkl-ast: Avoid double-frees by keeping track of frees, Jose E. Marchesi, 2022/10/27
    - Re: [PATCH v2] pkl-ast: Avoid double-frees by keeping track of frees, Arsen Arsenović <=
    - Re: [PATCH v2] pkl-ast: Avoid double-frees by keeping track of frees, Jose E. Marchesi, 2022/10/27