Re: GNU poke 2.0.91 pre-released in alpha.gnu.org

[Jose E. Marchesi]

Hi Bruno.

> On Linux/ia64:
>
> Builds with warnings:
>
> ../../jitter/jitter/jitter-heap.c:678: warning: 
> 'd.block_size_smallest_big_payload_in_bytes' is used uninitialized in this 
> function
>
> ../../jitter/jitter/jitter-print.c:548: warning: 'res' may be used 
> uninitialized in this function
> (The compiler doesn't infer that x != 0 implies i > 0.)
>
>
> Test suite fails:
>
>                 === poke tests ===
>
> Schedule of variations:
>     unix
>
> Running target unix
> Using /usr/share/dejagnu/baseboards/unix.exp as board description file for 
> target.
> Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
> Using /u/guest/bruno/poke-2.0.91/testsuite/config/unix.exp as 
> tool-and-target-specific interface file.
> Running /u/guest/bruno/poke-2.0.91/testsuite/poke.cmd/cmd.exp ...
> Running /u/guest/bruno/poke-2.0.91/testsuite/poke.libpoke/libpoke.exp ...
> ERROR: (DejaGnu) proc "lassign {5669 exp8 0 0} pid spawnid os_error_flag 
> value" does not exist.
> The error code is NONE

This is probably happening because the Tcl in the machine is old, and
`lassign' was introduced as a builtin in Tcl 8.5.

Pity, because the fact that cmd.exp passed is very promising :)
The patch below should fix this.

diff --git a/ChangeLog b/ChangeLog
index f93b9b86..d2131591 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2022-02-05  Jose E. Marchesi  <jemarch@gnu.org>
 
+       * testsuite/lib/poke.exp (verify_exit_status): Avoid using
+       lassign.
+
+2022-02-05  Jose E. Marchesi  <jemarch@gnu.org>
+
        * poke/pk-cmd-def.c (print_var_decl): Pass a `match' argument to
        regexec.
        (print_fun_decl): Likewise.
diff --git a/testsuite/lib/poke.exp b/testsuite/lib/poke.exp
index c911ac9d..7095b8e6 100644
--- a/testsuite/lib/poke.exp
+++ b/testsuite/lib/poke.exp
@@ -152,7 +152,10 @@ proc poke_test_cmd {cmd pattern} {
 # unexpected exits.
 
 proc verify_exit_status { executable wres } {
-    lassign $wres pid spawnid os_error_flag value
+    set pid [lindex $wres 0]
+    set spawnid [lindex $wres 1]
+    set os_error_flag [lindex $wres 2]
+    set value [lindex $wres 3]
     verbose "pid: $pid" 3
     verbose "spawnid: $spawnid" 3
     verbose "os_error_flag: $os_error_flag" 3