[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libpoke: Use uncollectable memory instead of GC roots
From: |
Jose E. Marchesi |
Subject: |
Re: [PATCH] libpoke: Use uncollectable memory instead of GC roots |
Date: |
Thu, 22 Apr 2021 16:21:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
>> I like this solution. We are effectively using the reference-counting
>> schema of the AST to allocate/free these fields, like the rest of the
>> node contents. Very good.
>>
>> I wasn't aware of the fact that GC_malloc_uncollectable effectively
>> adds a GC root... hopefully there is not a limit of objects allocated
>> this way? Because in that case we would be in exactly the same problem
>> than before :)
>>
>> If there isn't any limit, then this is OK for both master and
>> maint/poke-1.
>>
>
>
> It seems there isn't any limit.
> Pushed to master and maint/poke-1.
Thanks.
>> I assume this fix is fixing the hard-limit you was finding while loading
>> pickles?
>>
>
>
> The problem was with `testsuite/poke.mi-json/mi-json`, due to hard-limit
> of number of GC roots, we couldn't add new sample JSON files.
> This commit fixes that issue.
> And also this is useful for `format` (because of formater closure).
Oooh, so you are adding compiled formatted ala printers. Can't wait to
see the code :)