poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Introduce the builtins io_get_bias and io_set_bias


From: Egeyar Bagcioglu
Subject: Re: [PATCH] Introduce the builtins io_get_bias and io_set_bias
Date: Sun, 4 Apr 2021 12:22:31 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

I crafted the following patch and the corresponding test cases.

Please take a look and let me know.
Uoh it is nice to see someone else writing full-stack patches!  From
the lexer all the way down to the IOS :)

My only comment is that I would name the built-ins iobias and iosetbias
instead of io_get_bias and io_set_bias.  I think that matches better
with the rest of the io* API.  I chose using short names like that
because they are easier to type, and these are to be used often as
commands in the prompt.

If we can agree on that, the patch is OK for master.
Thanks!

Pushed with the suggested changes.

Regards
Ege



reply via email to

[Prev in Thread] Current Thread [Next in Thread]