poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] pickles: Add new pickle `pktest.pk`


From: Jose E. Marchesi
Subject: Re: [PATCH v3 1/2] pickles: Add new pickle `pktest.pk`
Date: Thu, 17 Dec 2020 07:00:00 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> This commit adds `pktest.pk` that provides testing facilities. It
> is a TAP (Test Anything Protocol) producer. That means tests written
> using `pktest` will generate TAP output. The output can be used by
> any TAP consumer (test harnesses that read TAP).

This looks great.

But I still don't like the fact that pktest_run exits.

Could we at least agree on changing pktest_run to not exit, and then
having a pktest_run_and_exit?

Not that I think it is worth it having the later, but it doesn't hurt :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]