[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] testsuite: Simplify poke.libpoke/values.c code using rea
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH 1/2] testsuite: Simplify poke.libpoke/values.c code using read_line |
|
Date: |
Fri, 20 Nov 2020 18:58:25 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Mohammad.
> 2020-11-20 Mohammad-Reza Nabipoor <m.nabipoor@yahoo.com>
>
> * bootstrap.conf (gnu_modules): Add module `read-file`.
> * testsuite/poke.libpoke/values.c: Add includes: `assert.h`,
> `stdint.h`, `err.h`, `read-file.h`.
> (compile_initial_poke_code): Remove.
> (compile_poke_expressions): Likewise.
> (test_pk_val_equal_p): Refactored to use `asprintf` for string
> manipulation. Use memory buffers instead of `FILE`s.
> (test_pk_equal_file): Renamed to `testcase_pk_val_equal_p` with new
> interface to deal with memory buffers instead of `FILE`s.
This is OK for master, provided you use C-like comments like /* .. */
Thanks!