Re: [PATCH v3] libpoke: free the buffer of stream device only in read mode

[Jose E. Marchesi]

> On Mon, Oct 19, 2020 at 12:04:05AM +0200, Jose E. Marchesi wrote:
>> 
>> Hi.
>> 
>> > -int ios_buffer_free (struct ios_buffer *buffer);
>> > +void
>> > +ios_buffer_free (struct ios_buffer *buffer);
>> 
>> Function prototypes should't feature the name of the function at the
>> first column, i.e. please use this instead:
>> 
>> void ios_buffer_free (struct ios_buffer *buffer);
>> 
>> Other than that, this is OK  for master.
>> Thanks!
>> 
>
> OK. I've just changed that function prototype to become consistent with other
> prototypes in `libpoke/ios-buffer.h` file.

Thanks.

>> PS: please don't forget to run make syntax-check before pushing your
>> changes.
>
> Thanks for the advice.
> I ran the `make syntax-check` and there are some problems. I'll send a patch
> to fix the issues and in that patch I'll fix the prototypes of 
> `ios-buffer.h`, too.

Yeah, I confess I am not always consistent in that regard... ahem ;)

> And what do you think about using `clang-format` to keep the formatting
> consistent?
> It's a mature tool and standalone tool. It also supports GNU code formatting
> style (`clang-format -style=gnu`).
>
> I suggest to  `clang-format` all the source files in a single commit, and keep
> that commit ID in a file. Git can be connfigured to ignore that commit for
> `git blame` (using `blame.ignoreRevsFile` option).
>
> WDYT?

Feel free to submit a patch in that regard, for review.
Thanks.