[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] JSON schema indentation and a function documentation fixes.
From: |
Jose E. Marchesi |
Subject: |
Re: [PATCH] JSON schema indentation and a function documentation fixes. |
Date: |
Mon, 27 Jul 2020 20:27:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Kostas.
> /* Build and return a poke struct.
>
> - NFIELDS is an uint<64> PK value specifying the number of fields
> + NFIELDS is an uint<64> poke value specifying the number of fields
> in the struct. This can be uint<64>0 for an empty struct.
>
> - TYPE is a type PK value specifying the type of the struct.
> + TYPE is a type poke value specifying the type of the struct.
I would spell it `Poke values' (with big P).
>
> The fields and methods in the created struct are initialized to
> PK_NULL.*/
Other than that, this is OK for master.
Thanks!