[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_obj
From: |
Jose E. Marchesi |
Subject: |
Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object. |
Date: |
Thu, 23 Jul 2020 11:27:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Kostas.
> Hello, this is the newest version of the patch, this time I hope without
> breaking the build. :).
Unfortunately, there seems to be more incompatible differences between
the newest version of libjson-c and previous versions:
- Seems like json_object_object_add now returns a value, whereas in the
Debian version it returns void:
../../poke/pk-mi-json.c:504:15: error: void value not ignored as it ought to
be
json_object_object_add (int_object, "type", type_object) !=
-1,
- Seems like json_object_object_add also changed its argument list:
../../poke/pk-mi-json.c:657:38: warning: passing argument 3 of
'json_object_object_add' makes pointer from integer without a cast
[-Wint-conversion]
- json_object_new_null doesn't seem to exist.
Also, there is an instance of a call to json_object_object_get, which
seems to be deprecated even in my older version of libjson:
../../poke/pk-mi-json.c:1332:3: warning: 'json_object_object_get' is deprecated
[-Wdeprecated-declarations]
search_object = json_object_object_get (poke_object, "PokeValue");
- [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Konstantinos Chasialis, 2020/07/14
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Jose E. Marchesi, 2020/07/15
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Konstantinos Chasialis, 2020/07/17
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Konstantinos Chasialis, 2020/07/17
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Jose E. Marchesi, 2020/07/21
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Konstantinos Chasialis, 2020/07/21
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Jose E. Marchesi, 2020/07/21
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Jose E. Marchesi, 2020/07/22
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Konstantinos Chasialis, 2020/07/22
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object.,
Jose E. Marchesi <=
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Konstantinos Chasialis, 2020/07/23
- Re: [PATCH] pk_mi_json convert functions between a pk_val and a json_object., Jose E. Marchesi, 2020/07/23