Re: [PATCH] Struct type attributes interface

[Jose E. Marchesi]

Hi Kostas!

    Hello, I have made the changes we discussed on previous thread about
    removing pk_alloc and pk_assert from pk_* interface and moved json-schema
    to etc/.

Can you please split the patch into two, one for the addition of
pk-mi-json-schema.json and the other for the work on libpoke?  That
helps reviewing and also applying unrelated parts that are ready.
    
    Author: kostasch <sdi1600195@di.uoa.gr>
    Date:   Wed Jul 1 01:46:51 2020
    
    Changes to pk-val interface for struct types
    
     ChangeLog                  |  11 ++++
     etc/pk-mi-json-schema.json | 284
    
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
     libpoke/libpoke.h          |  24 ++++----
     libpoke/pk-val.c           |  44 ++++++-------
     poke/pk-mi-json.c          |  46 +++++++-------
     poke/pk-mi-json.h          |   3 +-
     6 files changed, 352 insertions(+), 60 deletions(-)
    
    
    diff --git a/ChangeLog b/ChangeLog
    index b735ed0b..f3870098 100644
    --- a/ChangeLog
    +++ b/ChangeLog
    @@ -1,3 +1,14 @@
    +2020-07-01  Kostas Chasialis <sdi1600195@di.uoa.gr>
    +   * etc/pk-mi-json-schema.json : Moved from poke/
    +   * libpoke/libpoke.h (pk_allocate_struct_attrs) : Prototype.
    +     (pk_alloc) : Removed.
    +     (pk_assert) : Likewise.
    +   * libpoke/pk-val.c (pk_allocate_struct_attrs) : Define.
    +     (pk_alloc) : Removed.
    +     (pk_assert) : Likewise.
    +   * poke/pk-mi-json.c : Adaptive changes based on the changes above.
    +   * poke/pk-mi-json.h : Likewise.
    +

There are extra spaces before the indented lines like `(pk_alloc):
Removed.'  Also, there are extra spaces between ) and :.

    diff --git a/libpoke/libpoke.h b/libpoke/libpoke.h
    index 8a76d1ac..3b3533ed 100644
    --- a/libpoke/libpoke.h
    +++ b/libpoke/libpoke.h
    @@ -404,10 +404,6 @@ void pk_set_pretty_print (pk_compiler pkc, int
    pretty_print_p);
    
     #define PK_NULL 0x7ULL
    
    -void *pk_alloc (size_t size);
    -
    -void pk_assert (int expression);
    -
     /* Signed integers.  */

This doesn't look like a patch against master.  Please submit complete
patches that can be applied in master.

Also, your MUA seems to be splitting lines.  As mentioned already,
attaching your patches as text/x-patch or text/x-diff MIME attachments
would work just fine.