Re: [PATCH 4/6] poke: Add new function pk_assert_alloc

[Tim Rühsen]

On 07.05.20 18:39, Jose E. Marchesi wrote:
>     
>     +static inline void
>     +pk_assert_alloc(const void *m)
> 
> No space after function name.

Thanks. I wonder if we have a syntax-check rule for that somewhere.

> 
>     +{
>     +  if (!m)
>     +    {
>     +      pk_printf (_("out of memory\n"));
>     +      exit (EXIT_FAILURE);
>     +    }
>     +}
> 
> Please use a do { .. } while (0) instead of a compound statement.

Sorry, i can't follow. That is a function body and an if statement with
two lines in the block. Why should I apply do while here ???

You do not really want a
if (!m) do {
...
...
} while (0);

do you !?

Tim

signature.asc
Description: OpenPGP digital signature