[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Make some things const which need to be
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] Make some things const which need to be |
|
Date: |
Mon, 2 Mar 2020 09:18:39 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 3/1/20 12:41 PM, Jose E. Marchesi wrote:
Hi John.
This is OK for master.
Thanks!
---
-extern struct pk_cmd ios_cmd; /* pk-ios.c */
-extern struct pk_cmd file_cmd; /* pk-ios.c */
-static struct pk_cmd *dot_cmds[] =
+extern const struct pk_cmd ios_cmd; /* pk-ios.c */
+extern const struct pk_cmd file_cmd; /* pk-ios.c */
+extern const struct pk_cmd mem_cmd; /* pk-ios.c */
Hmm - my patch to add nbd_cmd conflicts with this. Let's get yours in
first, and I'll rebase mine on top (since I still have to polish the
testsuite portion of my patch).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org