[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ios: Avoid data leak and write-beyond-bounds in mem.
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH] ios: Avoid data leak and write-beyond-bounds in mem. |
|
Date: |
Mon, 02 Mar 2020 14:41:51 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi Eric.
* testsuite/poke.cmd/mem-1.pk: New test.
* testsuite/poke.cmd/mem-2.pk: Likewise.
* testsuite/poke.cmd/mem-3.pk: Likewise.
I would limit the tests in poke.cmd to make sure that the command itself
(in this case the dot-command) works and processes the arguments
properly, etc.
Testing that the memory is zeroed, that trying to grow more than 4098
bytes results in an exception, etc, fits better in poke.pkl/ios-mem-*.pk
tests, using `open' rather than `.mem'.
Other than that, this is OK for master.
Thanks! :)