Re: [PATCH] Require gawk at configure time

[darnir]

Hi Jose,

Sure. What I will do is, write a test to check if $(AWK) supports gensub. If it doesn't, try to find one that does. Else error out.

This will be a simple exercise in writing another autoconf macro

P.S. You asked, "who needs to write their own m4?". See, even Poke needs it now

On January 24, 2020 11:06:26 PM GMT+01:00, address@hidden wrote:

Hi Darshit!

    * configure.ac: Add AC_PROG_AWK to check for a valid implementation of
    awk
    * src/Makefile.am: Use $(AWK) when calling ras
    * src/ras: Change the shebang line to not force a path on location of
    awk

Thanks for the patch.
     configure.ac    | 1 +
     src/Makefile.am | 2 +-
     src/ras         | 2 +-
     3 files changed, 3 insertions(+), 2 deletions(-)
    
    diff --git a/configure.ac b/configure.ac
    index 0c652ebf..3275b7e8 100644
    --- a/configure.ac
    +++ b/configure.ac
    @@ -39,6 +39,7 @@ gl_EARLY
     LT_INIT
     AC_PROG_CC_C99
     AM_PROG_CC_C_O
    +AC_PROG_AWK

AC_PROG_AWK checks for any awk, doesn't it?

What we require is an awk implementation that supports gensub.  It is a
GNU extension, but implemented by other awks as well... just not all of
them.

The simplest solution would be to check for gawk, and fail if it is not
found.

The optimum solution would be to check at configure time whether $(AWK)
supports gensub or not.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.