poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add a new argument, set_cur to ios_open.


From: Jose E. Marchesi
Subject: Re: [PATCH] Add a new argument, set_cur to ios_open.
Date: Sat, 11 Jan 2020 22:49:54 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi Ege.

Thanks for the patch.
    
    diff --git a/src/pvm.jitter b/src/pvm.jitter
    index fa53d6ca..14801b38 100644
    --- a/src/pvm.jitter
    +++ b/src/pvm.jitter
    @@ -609,7 +609,7 @@ end
     instruction open () # ( STR -- INT )
       code
          char *filename = PVM_VAL_STR (JITTER_TOP_STACK ());
    -     int ret = ios_open (filename);
    +     int ret = ios_open (filename, 1);
     
          if (ret == IOS_ERROR)
            PVM_RAISE (PVM_E_IO);

There we should pass 0 to ios_open, because as we discussed today we
don't want `open' to set the current IO.

Given that, this is OK for master.
Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]