platform-testers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [platform-testers] new snapshot available: sed-4.5.48-58eb


From: Jim Meyering
Subject: Re: [platform-testers] new snapshot available: sed-4.5.48-58eb
Date: Thu, 13 Dec 2018 13:11:56 -0800

On Thu, Dec 13, 2018 at 12:18 PM Assaf Gordon <address@hidden> wrote:
> Thanks Jim!
> On 2018-12-12 11:24 p.m., Jim Meyering wrote:
> >
> > sed snapshot:
> >    https://meyering.net/sed/sed-4.5.48-58eb.tar.xz
> >
>
> I noticed one bug which I made in the latest 'obinary' test -
> I did not account that on BSD systems 'wc -c' adds whitespace prefixes,
> and the test error'd.
>
> ERROR: testsuite/obinary
> ========================
> [...]
> + printf a
> + sed cb
> + wc -c
> + size='       2'
> + framework_failure_ $'unexpected size \'       2\''
> + warn_ $'obinary.sh: set-up failure: unexpected size \'       2\''
> + printf '%s\n' $'obinary.sh: set-up failure: unexpected size \'       2\''
> obinary.sh: set-up failure: unexpected size '       2'
> + test 9 '=' 2
> + printf '%s\n' $'obinary.sh: set-up failure: unexpected size \'       2\''
> + sed 1q
> + Exit 99
> [...]
>
> The attached patch fixes it.
> All other test pass on Net/Open/Free-BSD, so perhaps it doesn't warrant
> another "pretest" release.

Thanks for the quick testing and fix, Assaf!
In your patch, you proposed:

> -size=$(wc -c < out1) \
> +size=$(LC_ALL=C wc -c < out1 | sed 's/^ *//') \

What do you think of using tr -d '[:space:]' in place of sed there, in
case some other implementation emits a TAB rather than spaces?

Feel free to push the fix either way.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]