pingus-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch to bug "Faller freezes sometimes"


From: Aggro
Subject: Patch to bug "Faller freezes sometimes"
Date: Tue, 11 Apr 2006 11:20:12 -0700 (PDT)

Faller freezes at least on one tutorial map. Bug
explained here:
http://www.cmhousing.net/pingus/wiki/pmwiki.php/Main/GameFeezeOnTutorialMapEntranceHighExitLow

The problem was a loop at src/actions/faller.cxx
Faller::update(). It tried to "Make Pingu bounce off
wall", and propably succeeded too well on that.
Because Pingu ended up bouncing there forever. I think
it was because the Pingu had collision with the wall
and that caused it to change direction from left to
right. But after that it noticed the collision again,
and changed from right to left, etc. and never got
over it.

I'm not sure if the fix is perfect. I basicly just
break the loop if situation where direction from left
to right, or from right to left needs to be changed,
instead of continueing in that loop. In all the tests
I did, it seemed to work fine, but it might be
possible that penguins could sometimes go through the
walls, but in such cases, the alternative would
propably be that the game would just freeze. So IMHO
this should be better than previous and at least it
seems to work ;)

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Attachment: faller_freezes
Description: 1035435126-faller_freezes


reply via email to

[Prev in Thread] Current Thread [Next in Thread]