[Phpgroupware-tracker] [bug #3687] class.sessions_db/php4.inc.php

[nobody]

=================== BUG #3687: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=3687&group_id=509

Changes by: Dave Hall <address@hidden>
Date: Fri 06/27/2003 at 08:40 (Australia/Melbourne)

            What     | Removed                   | Added
---------------------------------------------------------------------------
            Category | None                      | API - phpGWapi
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Have a look at the 16 branch - this has been fixed.



=================== BUG #3687: FULL BUG SNAPSHOT ===================


Submitted by: powerstat               Project: phpGroupWare                 
Submitted on: Mon 05/19/2003 at 19:23
Category:  API - phpGWapi             Bug Group:  None                      
Severity:  5 - Major                  Priority:  None                       
Resolution:  Fixed                    Assigned to:  None                    
Status:  Closed                       Component Version:  None              
Platform Version:  None               Reproducibility:  None                

Summary:  class.sessions_db/php4.inc.php

Original Submission:  Again these two classes are an example for NOT understood 
object oriented design especially of inheritance.

Both classes have the same "member variables" as well as the same methods with 
copy and pasted implementation!
For example:

DONTlist_methods and getuser_ip are copy and pasted.

A good design would have a parent class including these things - and a factory 
to construct a session object.


Follow-up Comments
*******************

-------------------------------------------------------
Date: Fri 06/27/2003 at 08:40       By: skwashd
Have a look at the 16 branch - this has been fixed.


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=3687&group_id=509

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/