Re: [pdf-devel] CCITT Fax Filter

[Gustavo Martin Domato]

On Sat, 2011-10-01 at 00:52 +0200, Georg Gottleuber wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 30.09.2011 23:34, Gustavo Martin Domato wrote:
> > There's a problem with the trunk. After performing 'make' I get:
> > 
> > pdf-filter.c: In function 'install_filters':
> > pdf-filter.c:1317: error: 'JBIG2DEC_GLOBAL_SEGMENTS_ARG' undeclared
> > (first use in this function)
> > pdf-filter.c:1317: error: (Each undeclared identifier is reported only
> > once
> > pdf-filter.c:1317: error: for each function it appears in.)
> > pdf-filter.c:1317: error: 'JBIG2DEC_PAGE_SIZE' undeclared (first use in
> > this function)
> > 
> > It seems that macro IS_FILTER_ARG compares with JBIG2DEC even when it's
> > not declared. I send a patch.
> 
> Yes, I can confirm this problem (if no HAVE_LIBJBIG2DEC). Your patch is
> ok, but we would need an extra macro for each further configuration
> option with arguments (and combinations). Are any further configuration
> option with arguments planed?
> 
> Maybe it is better to declare all values inside the enum (before the
> macro), or to make a function instead of the macro (so #ifdef can be
> used inside). But this can be done later too, so decide for yourself.
> 
> Regards,
> Georg
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.17 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
> 
> iEYEARECAAYFAk6GSDUACgkQ5sLITM1qIaKpPgCfWCDHzE8ueUyBpddgtzrXRQKd
> 4eEAnR9Itm/A2CTDbQv0KxZa2rn687t+
> =xAIr
> -----END PGP SIGNATURE-----

Yes, in case others were planned it would become a mess. So I settle for
the function idea. Here it goes.


Regards,
Gustavo

patch.tar.gz
Description: application/compressed-tar