[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Error report, few patches and part of testcases for pdf_
From: |
jemarch |
Subject: |
Re: [pdf-devel] Error report, few patches and part of testcases for pdf_time module. |
Date: |
Fri, 17 Apr 2009 00:14:51 +0200 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.92 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
Hi Łukasz.
1. pdf_time_init() -->pdf_time_context_init()
2. pdf_i64_div
4. Patch which adds 22 of 38 files with testcases of pdf_time module to
Makefile.am and runtests.c .
I applied those patches in the trunk, and also added the unit tests
for the time module.
(For future contributions please send bazaar merge directives instead
of plain diffs: you can use 'bzr send' to generate them. Also, please
include a suitable ChangeLog entry in the patch).
3. Functions :
pdf_status_t pdf_time_add_span()
pdf_status_t pdf_time_sub_span()
pdf_status_t pdf_time_diff()
and other functions in file src/base/pdf-time.c doesn't propagete status
variable, but always return PDF_OK.
Some of them don't check if pointer argument is null.
Yes, those functions should propagate the error status. Please note
that the documentation in doc/gnupdf.texi should then be updated to
reflect any new returned value.
6. pdf_time_from_string
6 of 13 test fails. This are mainly easy to fix bugs. I had put some
comments in tests that fails.
Thats is all rest of test schould be added in 2-3 weeks. However fixing bug
in pdf_time_add_cal_span would be handful since it can broke other tests.
BTW if you agree with bugs from point 3 and 6 i can write a patch for that
functions too.
Please.
Many thanks Łukasz.
---
Jose E. Marchesi
address@hidden
GNU Project
http://www.gnu.org