[pdf-devel] [flyspray] pdf_char_t sign

[GNU PDF Library]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Jose E. Marchesi (jemarch) 

Attached to Project - GNU PDF Library
Summary - pdf_char_t sign
Task Type - Sporadic Task
Category - Basic Types Module
Status - NEXT
Assigned To - 
Operating System - All
Severity - Medium
Priority - Normal
Reported Version - START
Due in Version - BASE-LAYER-0
Due Date - Undecided
Details - The 'pdf_char_t' is defined in 'pdf-types.h' as:

typedef unsigned char pdf_char_t;

It is quite common to pass both pdf_char_t and pdf_char_t* values to system 
functions expecting 'char' and 'char*' values.

The problem is that in some architectures (notably intel) the char data type is 
signed, and thus we get warnings like:

pointer targets in passing argument 1 of 'freopen' differ in signedness

Some places in the codebase makes use of explicit (char *) casts to avoid the 
warnings, but would be much better to change the definition of pdf_char_t to be 
a synonim of char (instead of unsigned char).

This task involves to:

1) Change the definition of pdf_char_t to be a synonim of char
2) Remove all the spurious (char *) casts from the codebase
3) Make sure that no code in the codebase relies on the sign of pdf_char_t


More information can be found at the following URL:
http://www.gnupdf.org/flyspray/index.php?do=details&task_id=64

You are receiving this message because you have requested it from the Flyspray 
bugtracking system.  If you did not expect this message or don't want to 
receive mails in future, you can change your notification settings at the URL 
shown above.